Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed scala compilation failure for play template #261

Merged
merged 1 commit into from
Nov 14, 2016
Merged

Fixed scala compilation failure for play template #261

merged 1 commit into from
Nov 14, 2016

Conversation

akhettar-zz
Copy link
Contributor

@akhettar-zz akhettar-zz commented Nov 10, 2016

I have changed the followings:

  • Made some of the parameters optional as the template expect them to be.

  • Using double quotation marks when calling cookieMessage.getOrElse.

I have compiled the template using the following command: "bundle exec rake build:play" and tested it on prototype. All works fine now

@akhettar-zz akhettar-zz changed the title Fixed scala compile issues for play template Fixed scala compilation failure for play template Nov 11, 2016
@robinwhittleton
Copy link
Contributor

robinwhittleton commented Nov 11, 2016

Thanks for this! I’m trying to track down someone else who uses Play (we don’t internally at GDS) to test this. If I can’t then I’ll see if I can set something up to test.

Can you let me know what the original issues you’re fixing were?

Copy link

@philsherry philsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍🏻

@robinwhittleton
Copy link
Contributor

Happy to merge with @philsherry’s OK. Thanks for the contribution!

@robinwhittleton robinwhittleton merged commit 30cd2ef into alphagov:master Nov 14, 2016
Guntrisoft added a commit to guidance-guarantee-programme/pension_guidance that referenced this pull request Dec 2, 2016
Makes the following changes:

Remove generated gov.uk from relative print links
alphagov/govuk_template#234

Fix extended footer on certain pages
alphagov/govuk_template#177

Degrade gracefully when external JS can’t be loaded
alphagov/govuk_template#248

Add docs for adding tabindex="-1" to fix the skiplink
alphagov/govuk_template#250

Logo fixes
alphagov/govuk_template#237

Remove external links styles
alphagov/govuk_template#231

Don’t include both html5shiv and html5shiv-printshiv
alphagov/govuk_template#254

Update govuk_frontend_toolkit to 5.0.0
alphagov/govuk_template#256

Fixed scala compilation failure for play template
alphagov/govuk_template#261
Guntrisoft added a commit to guidance-guarantee-programme/pension_guidance that referenced this pull request Dec 2, 2016
Makes the following changes:

Remove generated gov.uk from relative print links
alphagov/govuk_template#234

Fix extended footer on certain pages
alphagov/govuk_template#177

Degrade gracefully when external JS can’t be loaded
alphagov/govuk_template#248

Add docs for adding tabindex="-1" to fix the skiplink
alphagov/govuk_template#250

Logo fixes
alphagov/govuk_template#237

Remove external links styles
alphagov/govuk_template#231

Don’t include both html5shiv and html5shiv-printshiv
alphagov/govuk_template#254

Update govuk_frontend_toolkit to 5.0.0
alphagov/govuk_template#256

Fixed scala compilation failure for play template
alphagov/govuk_template#261
robinwhittleton pushed a commit that referenced this pull request Dec 9, 2016
- Increase skiplink colour contrast (PR #263)
- Fix Scala compile issues for Play template (PR #261)
@robinwhittleton robinwhittleton mentioned this pull request Dec 9, 2016
Guntrisoft added a commit to guidance-guarantee-programme/pension_guidance that referenced this pull request Dec 9, 2016
Fixes the following:

- Increase skiplink colour contrast
alphagov/govuk_template#263

- Fix Scala compile issues for Play template
alphagov/govuk_template#261
fofr pushed a commit to alphagov/static that referenced this pull request May 5, 2017
# 0.20.0

- Fix EJS template - PR #270 -
alphagov/govuk_template#270
- Add `theme-color` support to make the page surround in Chrome’s tab
view on Android match the black GOV.UK header - PR #278 -
alphagov/govuk_template#278
- Add `text-decoration-skip: ink` to all links on GOV.UK - PR #281 -
alphagov/govuk_template#281
- Improve contrast of links when focused - PR #272 -
alphagov/govuk_template#272
- Make header text colour black when focused - PR #274 -
alphagov/govuk_template#274

# 0.19.2

- Increase skiplink colour contrast - PR #263 -
alphagov/govuk_template#263
- Fix Scala compile issues for Play template - PR #261 -
alphagov/govuk_template#261

# 0.19.1

- Have focus outline appear outside of element rather than covering it
in Safari and Chrome - PR #259 -
alphagov/govuk_template#259
gemmaleigh pushed a commit to alphagov/govuk_elements that referenced this pull request Jun 8, 2017
- Increase skiplink colour contrast PR #263 - alphagov/govuk_template#263
- Fix Scala compile issues for Play template PR #261 - alphagov/govuk_template#261
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants