Add CI Terraform Plan for EKS #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredericfran-gds
force-pushed
the
ci_eks_setup
branch
from
669941d
to
e5f368c
Compare
sengi
reviewed
Aug 13, 2021
|
This work has a dependency on trello card iam-eks-configure-fulladmin-and-readonly-access-levels so we will wait for next sprint. |
fredericfran-gds
force-pushed
the
ci_eks_setup
branch
5 times, most recently
from
0727a83
to
2919d94
Compare
fredericfran-gds
force-pushed
the
ci_eks_setup
branch
from
2919d94
to
35f7d3a
Compare
sengi
reviewed
Aug 18, 2021
I was using that but forgot to remove the old script, will do now. |
fredericfran-gds
force-pushed
the
ci_eks_setup
branch
from
35f7d3a
to
c1d636b
Compare
Since we switch to EKS from ECS, this PR adds the terraform plans for the EKS modules and removes the ECS ones. **Testing** Tested by setting the CI pipeline to the one defined here and checking that the 2 terraform plans are done and reported to GitHub **Notes** We use plan with `-lock=false` and `-refresh=false` as done previously in ECS with justifications in #297 and #306 respectively. Ref: 1. [EKS cluster](#372) 2. [EKS cluster addons](#377) 3. [Concourse EKS pipeline](#378) 4. [add CI user to k8s](#391)
sengi
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we switch to EKS from ECS, this PR adds the terraform plans for
the EKS modules and removes the ECS ones.
Testing
Tested by setting the CI pipeline to the one defined here and
checking that the 2 terraform plans are done and reported to
GitHub
Notes
We use plan with
-lock=falseand-refresh=falseas donepreviously in ECS with justifications in #297 and #306 respectively.
Ref: