Disable refresh on CI plan #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This disables the default behavior of synchronizing the local Terraform state with remote objects before checking for configuration changes. This will make the CI planner test faster, since it reduces the number of API requests from refreshing the state. However, it makes the test less reliable since it ignores changes that have been made outside of Terraform, therefore risks the plan not being complete or correct.
sengi
approved these changes
May 25, 2021
fredericfran-gds
added a commit
that referenced
this pull request
Aug 18, 2021
Since we switch to EKS from ECS, this PR adds the terraform plans for the EKS modules and removes the ECS ones. **Testing** Tested by setting the CI pipeline to the one defined here and checking that the 2 terraform plans are done and reported to GitHub **Notes** We use plan with `-lock=false` and `-refresh=false` as done previously in ECS with justifications in #297 and #306 respectively. Ref: 1. [EKS cluster](#372) 2. [EKS cluster addons](#377) 3. [Concourse EKS pipeline](#378) 4. [add CI user to k8s](#391)
fredericfran-gds
added a commit
that referenced
this pull request
Aug 18, 2021
Since we switch to EKS from ECS, this PR adds the terraform plans for the EKS modules and removes the ECS ones. **Testing** Tested by setting the CI pipeline to the one defined here and checking that the 2 terraform plans are done and reported to GitHub **Notes** We use plan with `-lock=false` and `-refresh=false` as done previously in ECS with justifications in #297 and #306 respectively. Ref: 1. [EKS cluster](#372) 2. [EKS cluster addons](#377) 3. [Concourse EKS pipeline](#378) 4. [add CI user to k8s](#391)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables the default behavior of synchronizing the
local Terraform state with remote objects before checking
for configuration changes.
This will make the CI planner test faster, since it reduces
the number of API requests from refreshing the state.
However, it makes the test less reliable since it ignores
changes that have been made outside of Terraform, therefore
risks the plan not being complete or correct.