Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding contributors wreck #187

Closed
Berkmann18 opened this issue May 21, 2019 · 1 comment · Fixed by #259
Closed

Adding contributors wreck #187

Berkmann18 opened this issue May 21, 2019 · 1 comment · Fixed by #259

Comments

@Berkmann18
Copy link
Member

  • all-contributors-cli version: latest
  • node version: 11.12.0
  • yarn version: 1.16.0

Relevant code or config

{
  "projectName": "cz-cli",
  "projectOwner": "commitizen",
  "repoType": "github",
  "repoHost": "https://github.com",
  "files": [
    "AC.md"
  ],
  "imageSize": 100,
  "commit": false,
  "commitConvention": "angular",
  "contributors": [
    {
      "login": "jimthedev",
      "name": "Jim Cummins",
      "avatar_url": "https://avatars0.githubusercontent.com/u/108938?v=4",
      "profile": "https://jimthedev.com",
      "contributions": [
        "review"
      ]
    },
    {
      "login": "marionebl",
      "name": "Mario Nebl",
      "avatar_url": "https://avatars1.githubusercontent.com/u/4248851?v=4",
      "profile": "https://github.com/marionebl",
      "contributions": [
        "review"
      ]
    },
    {
      "login": "vagisha-nidhi",
      "name": "Vagisha Nidhi",
      "avatar_url": "https://avatars1.githubusercontent.com/u/13175100?v=4",
      "profile": "https://www.linkedin.com/in/vagisha-nidhi-891766126/",
      "contributions": [
        "review"
      ]
    },
    {
      "login": "plroebuck",
      "name": "P. Roebuck",
      "avatar_url": "https://avatars1.githubusercontent.com/u/16603429?v=4",
      "profile": "https://github.com/plroebuck",
      "contributions": [
        "review"
      ]
    },
    {
      "login": "giocodes",
      "name": "Sergio Gomez",
      "avatar_url": "https://avatars1.githubusercontent.com/u/19365690?v=4",
      "profile": "https://giocodes.github.io/portfolio/",
      "contributions": [
        "review"
      ]
    },
    {
      "login": "LinusU",
      "name": "Linus Unnebäck",
      "avatar_url": "https://avatars0.githubusercontent.com/u/189580?v=4",
      "profile": "http://linus.unnebäck.se/",
      "contributions": [
        "review"
      ]
    },
    {
      "login": "thierrymichel",
      "name": "Thierry Michel",
      "avatar_url": "https://avatars2.githubusercontent.com/u/806883?v=4",
      "profile": "http://thierrymichel.net",
      "contributions": [
        "review"
      ]
    }
  ],
  "contributorsPerLine": 7
}

What you did:
Ran ../all-contributors-cli/src/cli.js fetch

What happened:
Things seem to work properly until the JSON data read from the configPath becomes 0 after a few addContributors calls.

Reproduction repository:
Branch ml on this one

Problem description:
Either an I/O fail on the part of fs or a bad approach regarding adding multiple contributors (each one by one).

Suggested solution:
Having a function that can handle adding several contributors at once.

@Berkmann18 Berkmann18 changed the title Adding Adding contributors wreck May 21, 2019
@Berkmann18 Berkmann18 linked a pull request May 24, 2020 that will close this issue
Berkmann18 pushed a commit that referenced this issue May 24, 2020
* docs: update README.md

* docs: update .all-contributorsrc
@tenshiAMD tenshiAMD self-assigned this Sep 28, 2022
@Berkmann18
Copy link
Member Author

This doesn't seem to be an issue anymore on #196 so I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants