feat: support adding multiple users in a single message #127
Conversation
|
|
||
| const whos = contributors.map(({ who }) => who).join('--') | ||
| const safeWho = getSafeRef(whos) | ||
| // TODO: max length on branch name? |
There was a problem hiding this comment.
If we were to have a max length, what would it be?
There was a problem hiding this comment.
I'd suggest 255 chars. While it's true that people could limit themselves to using GitHub's ui for everything, and with recent changes, it's possible to renaming existing branches, branch names are generally stored in file systems and can be subject to the whims of file systems, some of whom don't particularly like very long file names (I'm not suggesting an 11 character limit...).
I suspect that would give you ~16-20 contributors, which is quite a lot.
There was a problem hiding this comment.
@jsoref That makes sense, yeah 255 chars seems good to me.
|
Do you think this should be supported by the CLI too? |
|
👋 Hey I think this would be a cool feature to land, and I would love to use it on some of my team's repos that already have a lot of existing contributors. Can I help move this PR along somehow? |
|
Hey there, I plan to look into it once I find some time to familiarize myself with the code base, I've blocked a day for that on Sep 16th, sorry it takes so long :( |
|
@gr2m Did you managed to get something working on this? |
|
I biggest problem is that the code base is very complex, it is using Probot in a serverless environment which the current version is not build for. With the next version of Probot that should be much simpler, so I focus on that first, because then it would be allow to spend some of my work hours to migrate The current code base is too hard to maintain and contribute to. |
|
Oh okay, the codebase is very complex. I wonder how we could go about simplifying it. |
|
@jakebolam @Berkmann18 @gr2m I think we can revisit this one. |
tenshiAMD
force-pushed
the
feature/support-adding-multiple-users-in-a-single-message
branch
from
1e4f93f
to
d33f252
Compare
tenshiAMD
changed the title
tenshiAMD
deleted the
feature/support-adding-multiple-users-in-a-single-message
branch
|
🎉 This PR is included in version 1.18.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closes #100, #146 and all-contributors/all-contributors#591