Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve PR branch issues #415

Merged
merged 1 commit into from
Sep 25, 2022
Merged

fix: resolve PR branch issues #415

merged 1 commit into from
Sep 25, 2022

Conversation

tenshiAMD
Copy link
Member

@tenshiAMD tenshiAMD commented Sep 17, 2022 •
edited
Loading

What:

Why:

  • resolve PR branch issues

How:

  • Refactor code
  • Add tests

Checklist:

  • Documentation
  • Ready to be merged
  • Added myself to contributors table.
    Bot Usage

@vercel
Copy link

vercel bot commented Sep 17, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
app ✅ Ready (Inspect) Visit Preview Sep 17, 2022 at 11:10AM (UTC)

@codecov
Copy link

codecov bot commented Sep 17, 2022 •
edited
Loading

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (819aecc) compared to base (89dbc86).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master      #415   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          379       392   +13     
  Branches        41        42    +1     
=========================================
+ Hits           379       392   +13
Impacted Files Coverage Δ
lib/modules/repository.js 100.00% <100.00%> (ø)
lib/setup-repository.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tenshiAMD tenshiAMD mentioned this pull request Sep 17, 2022
Closed
1 task
hertzg
hertzg approved these changes Sep 19, 2022
View reviewed changes
Copy link

@hertzg hertzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tenshiAMD
Copy link
Member Author

@all-contributors/core gentle ping

@tenshiAMD tenshiAMD merged commit 3a7a0d6 into master Sep 25, 2022
@tenshiAMD tenshiAMD deleted the fix/pr-branch-issues branch September 25, 2022 02:05
@github-actions
Copy link

🎉 This PR is included in version 1.16.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@tenshiAMD tenshiAMD mentioned this pull request Sep 25, 2022
Closed
@tenshiAMD
Copy link
Member Author

Related to #62.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

@hertzg hertzg hertzg approved these changes

@Berkmann18 Berkmann18 Awaiting requested review from Berkmann18

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loss of all-contributors.rc and empty pr when user already exists
3 participants
@tenshiAMD @gr2m @hertzg