Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: base off existing branch only if it exists and has an open pull request #338

Closed
wants to merge 4 commits into from
Closed

fix: base off existing branch only if it exists and has an open pull request #338

wants to merge 4 commits into from

Conversation

hertzg
Copy link

@hertzg hertzg commented Jan 7, 2021 •
edited
Loading

Fixes #336

⚠️ WIP ⚠️

TODO:

  • Save nock response snapshots for new pull request checks in happy paths

@vercel
Copy link

vercel bot commented Jan 7, 2021

@hertzg is attempting to deploy a commit to the All Contributors Team on Vercel.

A member of the Team first needs to authorize it.

Tyjuan1980
Tyjuan1980 approved these changes Dec 30, 2021
View reviewed changes
lib/modules/repository.js Outdated
async getPullRequestURL({ branchName }) {
try {
const results = await this.octokit.pulls.list({
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

lib/modules/repository.js Outdated
async getPullRequestURL({ branchName }) {
try {
const results = await this.octokit.pulls.list({
owner: this.owner,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicholas t walters

test/unit/setup-repository.test.js
@@ -0,0 +1,54 @@
const Repository = require("../../lib/modules/repository");
const { BranchNotFoundError } = require("../../lib/modules/errors");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias

tenshiAMD
tenshiAMD requested changes Sep 6, 2022
View reviewed changes
Copy link
Member

@tenshiAMD tenshiAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hertzg Hi, please rebase to master branch first and resolve all checks so we can proceed with this PR. Thanks!

@hertzg
Copy link
Author

hertzg commented Sep 7, 2022

Hey @tenshiAMD, unfortunately I don't have time to work on this pr now, but feel free to finish it if it's a priority right now or let me know and I can close this.

@tenshiAMD tenshiAMD requested a review from gr2m September 12, 2022 19:27
@tenshiAMD
Copy link
Member

tenshiAMD commented Sep 12, 2022 •
edited
Loading

@gr2m I think this is the current behavior now. See any differences? Please check. Thanks.

@tenshiAMD tenshiAMD changed the title WIP fix: base off existing branch only if it exists and has an open pull request fix: base off existing branch only if it exists and has an open pull request Sep 12, 2022
@tenshiAMD
Copy link
Member

@hertzg Hi. Looks like the other tests got broken. Any ideas? What else are we missing here?

@gr2m
Copy link
Contributor

gr2m commented Sep 12, 2022

I'll try to have look this week but can't promise

@hertzg
Copy link
Author

hertzg commented Sep 13, 2022 •
edited
Loading

@tenshiAMD Are you sure they just broke?

There’s a TODO on top of the PR

TODO:

  • Save nock response snapshots for new pull request checks in happy paths

@tenshiAMD
Copy link
Member

@tenshiAMD Are you sure they just broke?

There’s a TODO on top of the PR

TODO:

  • Save nock response snapshots for new pull request checks in happy paths

@hertzg yes I already update the snapshots, you can review the recent checks in this PR

@tenshiAMD tenshiAMD mentioned this pull request Sep 17, 2022
Merged
3 tasks
@tenshiAMD
Copy link
Member

Closing for now. Recreated to a new PR #415.

@tenshiAMD tenshiAMD closed this Sep 17, 2022
@Mhmonicox Mhmonicox mentioned this pull request Feb 16, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jun 1, 2023
Open
@Mhmonicox Mhmonicox mentioned this pull request Jul 5, 2023
Open
@Mhmonicox Mhmonicox mentioned this pull request Aug 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenshiAMD tenshiAMD tenshiAMD requested changes

@Tyjuan1980 Tyjuan1980 Tyjuan1980 approved these changes

@gr2m gr2m Awaiting requested review from gr2m

Assignees
No one assigned
Labels
pinned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loss of all-contributors.rc and empty pr when user already exists
4 participants
@hertzg @tenshiAMD @gr2m @Tyjuan1980