Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instantsearch): warn deprecated usage of searchParameters #4151

Merged
merged 2 commits into from
Oct 1, 2019

Conversation

francoischalifour
Copy link
Member

This PR targets the develop branch, thus InstantSearch.js 3.

This displays a development warning when using searchParameters on InstantSearch.js 3. This option doesn't exist anymore on v4 and therefore it's better to warn users before reading the migration guide. We instead advise for using the configure widget.

@francoischalifour francoischalifour requested a review from a team September 30, 2019 15:12
@ghost ghost requested review from eunjae-lee and yannickcr and removed request for a team September 30, 2019 15:12
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@francoischalifour francoischalifour merged commit 18e1c36 into develop Oct 1, 2019
@francoischalifour francoischalifour deleted the fix/searchParameters-warning branch October 1, 2019 11:35
francoischalifour added a commit that referenced this pull request Oct 8, 2019
# [3.7.0](v3.5.4...v3.7.0) (2019-10-08)

### Bug Fixes

* **clearRefinements:** reset page to 0 ([#3936](#3936)) ([7378a0a](7378a0a))
* **connectSortBy:** never update the initial index ([#4015](#4015)) ([bc0f9e2](bc0f9e2))
* **deps:** update dependency instantsearch.js to v3.5.4 ([#3929](#3929)) ([eff84c5](eff84c5))
* **deps:** update dependency instantsearch.js to v3.6.0 ([#4021](#4021)) ([7719bba](7719bba))
* **enhanceConfiguration:** deduplicate the hierarchicalFacets ([#3966](#3966)) ([baf8a35](baf8a35))
* **examples:** fix IE11 compatibility for e-commerce demo ([#4049](#4049)) ([dc6f350](dc6f350))
* **examples:** fix missing polyfill in e-commerce demo ([#4076](#4076)) ([4bf3ab3](4bf3ab3))
* **hierarchicalFacets:** prevent different rootPath on same attribute ([#3965](#3965)) ([5ee79fa](5ee79fa))
* **instantsearch:** warn deprecated usage of  ([#4151](#4151)) ([18e1c36](18e1c36))
* **menuSelect:** unmount component ([#3911](#3911)) ([f6debce](f6debce))
* **rangeInput:** unmount component ([#3910](#3910)) ([f6c29e8](f6c29e8))
* **refinementList:** fix showMore button to work after search ([#3082](#3082)) ([23e46b6](23e46b6))
* pass noop as default value to unmountFn at connectors ([#3955](#3955)) ([7c38744](7c38744))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants