fix(rangeInput): unmount component #3910
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rangeInput
was not able to be removed. The unmount function was not provided. The PR fix this issue.Note that even without the unmount function the widget should not throw. An error is raised because we don't provide a default value to the unmount function or check the value for the unmount function. This issue concern most of the connectors, that's why I didn't address it inside the PR.
Before
After