fix(menuSelect): unmount component #3911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
francoischalifour and
yannickcr
and removed request for
a team
|
Deploy preview for instantsearchjs ready! Built with commit 145f3a3 |
francoischalifour
approved these changes
Jul 1, 2019
Haroenv
added a commit
that referenced
this pull request
Jul 30, 2019
* **clearRefinements:** reset page to 0 ([#3936](#3936)) ([7378a0a](7378a0a)) * pass noop as default value to unmountFn at connectors ([#3955](#3955)) ([7c38744](7c38744)) * **enhanceConfiguration:** deduplicate the hierarchicalFacets ([#3966](#3966)) ([baf8a35](baf8a35)) * **hierarchicalFacets:** prevent different rootPath on same attribute ([#3965](#3965)) ([5ee79fa](5ee79fa)) * **menuSelect:** unmount component ([#3911](#3911)) ([f6debce](f6debce)) * **rangeInput:** unmount component ([#3910](#3910)) ([f6c29e8](f6c29e8)) * **refinementList:** fix showMore button to work after search ([#3082](#3082)) ([23e46b6](23e46b6))
francoischalifour
added a commit
that referenced
this pull request
Oct 8, 2019
# [3.7.0](v3.5.4...v3.7.0) (2019-10-08) ### Bug Fixes * **clearRefinements:** reset page to 0 ([#3936](#3936)) ([7378a0a](7378a0a)) * **connectSortBy:** never update the initial index ([#4015](#4015)) ([bc0f9e2](bc0f9e2)) * **deps:** update dependency instantsearch.js to v3.5.4 ([#3929](#3929)) ([eff84c5](eff84c5)) * **deps:** update dependency instantsearch.js to v3.6.0 ([#4021](#4021)) ([7719bba](7719bba)) * **enhanceConfiguration:** deduplicate the hierarchicalFacets ([#3966](#3966)) ([baf8a35](baf8a35)) * **examples:** fix IE11 compatibility for e-commerce demo ([#4049](#4049)) ([dc6f350](dc6f350)) * **examples:** fix missing polyfill in e-commerce demo ([#4076](#4076)) ([4bf3ab3](4bf3ab3)) * **hierarchicalFacets:** prevent different rootPath on same attribute ([#3965](#3965)) ([5ee79fa](5ee79fa)) * **instantsearch:** warn deprecated usage of ([#4151](#4151)) ([18e1c36](18e1c36)) * **menuSelect:** unmount component ([#3911](#3911)) ([f6debce](f6debce)) * **rangeInput:** unmount component ([#3910](#3910)) ([f6c29e8](f6c29e8)) * **refinementList:** fix showMore button to work after search ([#3082](#3082)) ([23e46b6](23e46b6)) * pass noop as default value to unmountFn at connectors ([#3955](#3955)) ([7c38744](7c38744))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
menuSelectwas not able to be removed. The unmount function was not provided. The PR fix this issue.Note that even without the unmount function the widget should not throw. An error is raised because we don't provide a default value to the unmount function or check the value for the unmount function. This issue concern most of the connectors, that's why I didn't address it inside the PR.
Before
After