-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(selector): root classname is applied twice #2423
Merged
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8b5d8fa
fix(selector): root classname is applied twice
d28e342
Merge branch 'develop' into fix/select-css-class
bobylito 86f0782
Merge branch 'develop' into fix/select-css-class
Haroenv 9d246dd
chore(test): update snapshot
9948e10
Merge branch 'develop' into fix/select-css-class
bobylito 3020926
chore(functional-tests): add form-control using select
360d6fc
Merge branch 'develop' into fix/select-css-class
bobylito 7a7ef33
Merge branch 'fix/select-css-class' of github.com:algolia/instantsear…
81c426e
Merge branch 'develop' into fix/select-css-class
vvo 4274d9b
chore(test): update test to validate the usage of the new key
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,13 +31,14 @@ const usage = `Usage: | |
sortBySelector({ | ||
container, | ||
indices, | ||
[cssClasses.{root,item}={}], | ||
[cssClasses.{root,select,item}={}], | ||
[autoHideContainer=false] | ||
})`; | ||
|
||
/** | ||
* @typedef {Object} SortByWidgetCssClasses | ||
* @property {string|string[]} [root] CSS classes added to the parent `<select>`. | ||
* @property {string|string[]} [root] CSS classes added to the outer `<div>`. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
* @property {string|string[]} [select] CSS classes added to the parent `<select>`. | ||
* @property {string|string[]} [item] CSS classes added to each `<option>`. | ||
*/ | ||
|
||
|
@@ -92,6 +93,9 @@ export default function sortBySelector( | |
|
||
const cssClasses = { | ||
root: cx(bem(null), userCssClasses.root), | ||
// We use the same class to avoid regression on existing website. It needs to be replaced | ||
// eventually by `bem('select') | ||
select: cx(bem(null), userCssClasses.select), | ||
item: cx(bem('item'), userCssClasses.item), | ||
}; | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update this test to not have undefined inside it? And check if select css class is actually read?