Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(selector): root classname is applied twice #2423

Merged
merged 10 commits into from
Oct 3, 2017
Merged

fix(selector): root classname is applied twice #2423

merged 10 commits into from
Oct 3, 2017

Commits on Oct 2, 2017

  1. fix(selector): root classname is applied twice 

    The implementation of the React `selector` was applying the root css
classname that is already applied by the headerfooter. In order to
prevent regressions and let user customize the <select>, this patch adds
a new key to customize cssClasses in Selector bases widgets, and this
new key has the root value to avoid breaking the current implementations.

Fix #2396 #2397
    Alex S committed Oct 2, 2017
    Configuration menu
    Copy the full SHA
    8b5d8fa View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into fix/select-css-class

    @bobylito
    bobylito authored Oct 2, 2017
    Configuration menu
    Copy the full SHA
    d28e342 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2017

  1. Merge branch 'develop' into fix/select-css-class

    @Haroenv
    Haroenv authored Oct 3, 2017
    Configuration menu
    Copy the full SHA
    86f0782 View commit details
    Browse the repository at this point in the history

  2. chore(test): update snapshot

    Alex S committed Oct 3, 2017
    Configuration menu
    Copy the full SHA
    9d246dd View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into fix/select-css-class

    @bobylito
    bobylito authored Oct 3, 2017
    Configuration menu
    Copy the full SHA
    9948e10 View commit details
    Browse the repository at this point in the history

  4. chore(functional-tests): add form-control using select 

    The new cssClasses key so that we check that all 3 can have custom css
classes. Interestingly the key was used but not implemented already :/
    Alex S committed Oct 3, 2017
    Configuration menu
    Copy the full SHA
    3020926 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into fix/select-css-class

    @bobylito
    bobylito authored Oct 3, 2017
    Configuration menu
    Copy the full SHA
    360d6fc View commit details
    Browse the repository at this point in the history

  6. Merge branch 'fix/select-css-class' of github.com:algolia/instantsear… 

    …ch.js into fix/select-css-class
    Alex S committed Oct 3, 2017
    Configuration menu
    Copy the full SHA
    7a7ef33 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'develop' into fix/select-css-class

    @vvo
    vvo authored Oct 3, 2017
    Configuration menu
    Copy the full SHA
    81c426e View commit details
    Browse the repository at this point in the history

  8. chore(test): update test to validate the usage of the new key

    Alex S committed Oct 3, 2017
    Configuration menu
    Copy the full SHA
    4274d9b View commit details
    Browse the repository at this point in the history