fix(selector): root classname is applied twice #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of the React `selector` was applying the root css classname that is already applied by the headerfooter. In order to prevent regressions and let user customize the <select>, this patch adds a new key to customize cssClasses in Selector bases widgets, and this new key has the root value to avoid breaking the current implementations. Fix #2396 #2397
|
Deploy preview ready! Built with commit 8b5d8fa https://deploy-preview-2423--algolia-instantsearch.netlify.com |
|
Deploy preview ready! Built with commit 4274d9b https://deploy-preview-2423--algolia-instantsearch.netlify.com |
Haroenv
previously requested changes
Oct 3, 2017
|
I need push them 🤣 |
|
Good thing that we have argos :D |
The new cssClasses key so that we check that all 3 can have custom css classes. Interestingly the key was used but not implemented already :/
…ch.js into fix/select-css-class
|
The select was used but not implemented. The change is expected on argos. |
vvo
reviewed
Oct 3, 2017
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| exports[`Selector should render <Selector/> with numbers 1`] = ` | |||
| <select | |||
| className="custom-root" | |||
| className={undefined} | |||
There was a problem hiding this comment.
Should we update this test to not have undefined inside it? And check if select css class is actually read?
vvo
reviewed
Oct 3, 2017
| [autoHideContainer=false] | ||
| })`; | ||
|
|
||
| /** | ||
| * @typedef {Object} SortByWidgetCssClasses | ||
| * @property {string|string[]} [root] CSS classes added to the parent `<select>`. | ||
| * @property {string|string[]} [root] CSS classes added to the outer `<div>`. |
bobylito
force-pushed
the
fix/select-css-class
branch
from
4496076
to
4274d9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of the React component
Selectorwas applying therootcssclasses that were already applied by the headerfooter. In order to
prevent regressions and let user customize the , this patch adds a new key to customize cssClasses in Selector bases widgets (select), and this new key has the root value to avoid breaking the current implementations. Fix #2396 #2397