pagination: buggy first/previous/next/last logic

[pixelastic]

I feel like the logic used to hide/show the various previous/first/next/last links is buggy. Here are some screenshots:

^ I'm on the first page, everything is alright.

^ I'm on the second page, I don't think the "<<" (first page) link is needed (redundant with "<" previous)

^ 4th page, everything is alright

^ 5th page, oops the 6th page link disappeared. And I have both next and last (last might be useless here, and related to #594)

[vvo]

I think, the 6th page disappearing is a bug we need to fix (bug)

As for the "I am on second page", we should keep showing the <<, not really a big deal nor something we should again weight our preference I feel.

Others are good as you said

[Shipow]

Some thoughts because obvious always win:

• It's not recommended to use only icons most of the time so plain text 'previous', 'first', .. should be default.
• it's not recommended to hide elements from an ui, so visible + disabled should be the default.
• the current representation does not inform about the total pages (and when all pages are displayed first/last links are redondant, useless and even confusing when not labelled.
• There is a lot of different config for pagination, no silver bullet, it really depends of the usecase.
• I'm personally more often attracted by ellipsis solution (always show 3 first pages, and last one)

[bobylito]

Ok let's fix the obvious bug then :)

[pixelastic]

Ok, let's keep this issue focused on the 6th page bug then. We'll have to discuss a bit more to see how we want to tackle the other pagination UI questions

[bobylito]

Pull request is here : #675