Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starRating disappearing once clicked in live docs #615

Closed
vvo opened this issue Nov 16, 2015 · 6 comments
Closed

starRating disappearing once clicked in live docs #615

vvo opened this issue Nov 16, 2015 · 6 comments
Assignees
Milestone

Comments

@vvo
Copy link
Contributor

vvo commented Nov 16, 2015

star-rating

@vvo vvo added this to the 1.0.0 milestone Nov 16, 2015
@vvo
Copy link
Contributor Author

vvo commented Nov 16, 2015

No error in console

@vvo vvo added the ready label Nov 16, 2015
@Jerska Jerska self-assigned this Nov 17, 2015
@Jerska Jerska added in progress and removed ready labels Nov 17, 2015
@Jerska
Copy link
Member

Jerska commented Nov 17, 2015

I didn't see that coming : The starRating widget is actually using the price as a facet. Using Math.round works for displaying the values, but doesn't for refining since we're refining on integers ORs (3 OR 4 OR 5). Should I randomly assign notes to our dataset?
Moreover, should we use a disjunctive numeric refinement and use myfacet>val instead of (myfacet:val,myfacet:val+1,...,myfacet:max)? It will break implems using strings for their stars but the current implementation breaks with floats, and I think we'll have more float scores than string ones.
This would allow us to still use price.

@redox
Copy link
Contributor

redox commented Nov 17, 2015

Hmmm, not sure about that. The goal was really to use a facet and not a numerical attribute to ensure the counts & refinements are working. I'll need to check if I have another fix (I was more thinking of removing the Math.round and ensure the dataset use 0..5 integer values).

@vvo
Copy link
Contributor Author

vvo commented Nov 17, 2015

As a side note, I fixed the doc by adding a randomly generated "rating" attribute in the instant_search data so that we do not use the price attribute anymore

Its also more relevant in the docs to talk about stars and rating

@vvo
Copy link
Contributor Author

vvo commented Nov 17, 2015

This one was done, open another specific issue for what you want to further fix @jerskouille

@vvo vvo closed this as completed Nov 17, 2015
@vvo vvo removed the in progress label Nov 17, 2015
@redox
Copy link
Contributor

redox commented Nov 18, 2015

This one was done, open another specific issue for what you want to further fix @jerskouille

Thx @vvo

vvo pushed a commit that referenced this issue Nov 25, 2015
<a name="1.1.0-beta"></a>
# [1.1.0-beta](v1.0.0...v1.1.0-beta) (2015-11-25)

### Bug Fixes

* **pagination:** fix #668 edge case ([d8f1196](d8f1196)), closes [#668](#668)
* **priceRanges:** Remove round from first range ([bf82395](bf82395))
* **starRating:** Retrieve the correct count and use numericRefinement ([f00ce38](f00ce38)), closes [#615](#615)

### Features

* **hierarchical:** expose rootPath and showParentLevel ([6e9bb7c](6e9bb7c))
vvo pushed a commit that referenced this issue Nov 26, 2015
<a name="1.1.0"></a>
# [1.1.0](v1.0.0...v1.1.0) (2015-11-26)

### Bug Fixes

* **pagination:** fix #668 edge case ([d8f1196](d8f1196)), closes [#668](#668)
* **priceRanges:** Remove round from first range ([bf82395](bf82395))
* **slider:** hide the slider when stats.min=stats.max ([42e4b64](42e4b64))
* **starRating:** Retrieve the correct count and use numericRefinement ([f00ce38](f00ce38)), closes [#615](#615)

### Features

* **hierarchical:** expose rootPath and showParentLevel ([6e9bb7c](6e9bb7c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants