Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination should probably not have a "Last" button #594

Closed
Jerska opened this issue Nov 13, 2015 · 7 comments
Closed

Pagination should probably not have a "Last" button #594

Jerska opened this issue Nov 13, 2015 · 7 comments

Comments

@Jerska
Copy link
Member

Jerska commented Nov 13, 2015

Google doesn't do it. They don't even provide a first
Page 15 on Google

Amazon doesn't do it. However, they explicitely show that they only display 20 pages.
Page 15 on Amazon

We have a 1000 hits limitation that will confuse people if they click >> and end up on page let's say 20 when we say "100 000 results found".

So in the end, I think we should probably hide it by default or just completely remove it.

@bobylito
Copy link
Contributor

hiding it by default is nice indeed.

@redox
Copy link
Contributor

redox commented Nov 13, 2015

👍 to remove it

@vvo
Copy link
Contributor

vvo commented Nov 16, 2015

Hiding by default is good, if you have one for the start of the pagination, people needing the end will ask for it.

@vvo
Copy link
Contributor

vvo commented Feb 29, 2016

This needs an API proposal because hiding it by adding display: none is not an option: it would require the user to override the display property somehow.

So better have a "showLastButton" bool that will add/remove a hidden class?

@Jerska
Copy link
Member Author

Jerska commented Feb 29, 2016

So better have a "showLastButton" bool that will add/remove a hidden class?

👍 I would just remove it from the DOM though, some people might use display: xxx hacks otherwise if they missed the option in the documentation.

@vvo
Copy link
Contributor

vvo commented Mar 1, 2016

Ah yes so showLastButton:false would remove the last pagination from the DOM, wfm

@vvo
Copy link
Contributor

vvo commented Mar 1, 2016

moved to #883

@vvo vvo closed this as completed Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants