fix: pass noop as default value to unmountFn at connectors #3955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for instantsearchjs ready! Built with commit 366e21a |
Haroenv
approved these changes
Jul 15, 2019
Yup, I went through all the connectors one by one. |
samouss
reviewed
Jul 15, 2019
There was a problem hiding this comment.
The usage should have been covered with a test. We have one for infiniteHits for example.
Haroenv
added a commit
that referenced
this pull request
Jul 30, 2019
* **clearRefinements:** reset page to 0 ([#3936](#3936)) ([7378a0a](7378a0a)) * pass noop as default value to unmountFn at connectors ([#3955](#3955)) ([7c38744](7c38744)) * **enhanceConfiguration:** deduplicate the hierarchicalFacets ([#3966](#3966)) ([baf8a35](baf8a35)) * **hierarchicalFacets:** prevent different rootPath on same attribute ([#3965](#3965)) ([5ee79fa](5ee79fa)) * **menuSelect:** unmount component ([#3911](#3911)) ([f6debce](f6debce)) * **rangeInput:** unmount component ([#3910](#3910)) ([f6c29e8](f6c29e8)) * **refinementList:** fix showMore button to work after search ([#3082](#3082)) ([23e46b6](23e46b6))
francoischalifour
added a commit
that referenced
this pull request
Oct 8, 2019
# [3.7.0](v3.5.4...v3.7.0) (2019-10-08) ### Bug Fixes * **clearRefinements:** reset page to 0 ([#3936](#3936)) ([7378a0a](7378a0a)) * **connectSortBy:** never update the initial index ([#4015](#4015)) ([bc0f9e2](bc0f9e2)) * **deps:** update dependency instantsearch.js to v3.5.4 ([#3929](#3929)) ([eff84c5](eff84c5)) * **deps:** update dependency instantsearch.js to v3.6.0 ([#4021](#4021)) ([7719bba](7719bba)) * **enhanceConfiguration:** deduplicate the hierarchicalFacets ([#3966](#3966)) ([baf8a35](baf8a35)) * **examples:** fix IE11 compatibility for e-commerce demo ([#4049](#4049)) ([dc6f350](dc6f350)) * **examples:** fix missing polyfill in e-commerce demo ([#4076](#4076)) ([4bf3ab3](4bf3ab3)) * **hierarchicalFacets:** prevent different rootPath on same attribute ([#3965](#3965)) ([5ee79fa](5ee79fa)) * **instantsearch:** warn deprecated usage of ([#4151](#4151)) ([18e1c36](18e1c36)) * **menuSelect:** unmount component ([#3911](#3911)) ([f6debce](f6debce)) * **rangeInput:** unmount component ([#3910](#3910)) ([f6c29e8](f6c29e8)) * **refinementList:** fix showMore button to work after search ([#3082](#3082)) ([23e46b6](23e46b6)) * pass noop as default value to unmountFn at connectors ([#3955](#3955)) ([7c38744](7c38744))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Many of the connectors doesn't have default value of
unmountFn. When users create custom widget using the connectors and if they don't provideunmountFn, removing the widget will throw an error.So this PR adds
noopas the default value ofunmountFnto all the connectors.Result
All the connectors have
noopas default value ofunmountFn.