fix(lodash/intersection): replace with custom implementation #718

tkrugg · 2019-06-21T14:29:36Z

I reverted the commit replacing intersection than copie the current implem into a new intersection function
I add something to avoid duplicates and some tests.

This reverts commit 04b21b4.

Haroenv · 2019-06-24T07:40:29Z

I'm sure this has a reason, but what was wrong with the version without helper function?

src/SearchParameters/index.js

samouss · 2019-06-24T07:41:57Z

@Haroenv The previous version didn't remove the duplicates, but the Lodash version does.

Haroenv · 2019-06-24T07:44:06Z

maybe best to also add a test to its usage to show what this is fixing

Haroenv

lgtm qua code, but agree with sam on the comment

* Revert "refactor(lodash): intersection (#696)" This reverts commit 04b21b4. * fix(lodash/intersection): replace with custom implementation

* fix(merge): change implementation (#716) 29c2138 * chore: mention remaining changes f756947 * chore(deps): update circleci/node:8.15.1 docker digest to ef1a0c4 (#715) f4dab89 * chore(lodash): remove _.omit (#655) 7db8b4c * chore(lodash): remove lodash from dependency list (#705) a63ec6b, closes #552 * chore(release): allow canary release (#712) 3eb087c * chore(removeHierarchicalFacetRefinement): remove error if not refined (#747) e68ecfe * chore: merge develop into master (#750) 53c7c62 * chore: remove Bower support (#711) e7518e2 * chore(ts): add methods d051f79 * chore(ts): add ruleContexts to SP 4bdc4a4 * chore(ts): add searchOnlyWithDerivedHelpers (#739) c6aa31b * chore(ts): publish definition file too 1813462 * chore(TS): isNumericRefined has only one required argument cac8fc3 * chore(warn): remove unused function (lodash.bind) (#682) c59b7e3 * chore: update release command 0989880 * docs: add link to wiki 3598f2a * docs: update event signature (#701) bbe4634 * docs(migration): mention changed methods (#732) f95e680 * docs(next): add migration guide 8430137 * docs(serverUsed): mention getRankingInfo (#706) f258c2a, closes #500 * feat: implement dedicated reset page method (#673) 666501e * feat(getState): remove filter option (#707) ac52791 * feat(getState): remove getState (#708) 7de698c * feat(requestBuilder): prevent needless extra requests for empty refinements (#737) db0a392 * feat(search): allow the search only with Derived Helpers (#704) aa128fc * feat(SearchParameters): avoid undefined values (#703) 9757e0a * feat(typescript): move typings inline (#719) a12272e * fix(defaults): remove const 48a0c48 * fix(errors): remove isRefined (#731) 5761885 * fix(getConjunctiveRefinements): no error when requested facet is not conjunctive (#724) cf852e7 * fix(getDisjunctiveRefinements): remove error (#725) 211e390 * fix(getExcludeRefinements): replace error by default value (#726) 9d7ae87 * fix(getFacetStats): remove error (#721) 96b6ec8 * fix(getFacetValues): don't throw error when there's no facet (#720) e15e39e * fix(getHierarchicalFacetBreadcrumb): don't throw an error (#723) 40e1d61 * fix(isDisjunctiveFacetRefined): return false if not in disjunctiveFacets (#729) 13ec09b * fix(isExcludeRefined): remove error in favor of false (#728) 3f0ab6b * fix(isFacetRefined): return false if facet isn't declared (#727) 7151f56 * fix(isHierarchicalFacetRefined): return false if refinement isn't a facet (#730) 89fa010 * fix(lodash/intersection): replace with custom implementation (#718) 00dfb4e * fix(removeXFacet): make sure this fully removes empty arrays (#743) ea5a22a * fix(results): remove lodash looping over objects (#648) bb025c2, closes #258 * fix(sortBy): compare whole prefix instead of first character (#702) b85fb50, closes #702 * fix(toggleRefinement): keep an empty array when clearing (#738) 5b3fc11 * fix(types): add state.removeNumericRefinement (#742) e58c24a * refactor(addAgent): remove duplicate code (#657) d023efd * refactor(error): use object vs list of arguments (#700) 722eceb * refactor(lodash): compact (#689) 284efa5 * refactor(lodash): forOwn (#697) eae367a * refactor(lodash): intersection (#696) 25822a5 * refactor(lodash): map & trim (#679) 357fcb7 * refactor(lodash): merge (#694) 92bced4 * refactor(lodash): partial & partialRight (#693) 7ceea2f * refactor(lodash): remove filter (#685) 249d2e6 * refactor(lodash): remove flatten (#695) 9da0e08 * refactor(lodash): remove forEach (#674) 8c93765 * refactor(lodash): remove reduce (#678) 7907805 * refactor(lodash): remove simple functions (#656) c309ffa * refactor(lodash): remove startsWith (#690) bb00933 * refactor(lodash): replace defaults with pure alternative (#692) ee07132 * refactor(lodash): replace find & findIndex (#687) 92e7c23 * refactor(lodash): replace orderBy (#698) bb2b31e * refactor(lodash): sumBy (#688) a538bd9 * refactor(result): use object vs list of arguments (#699) 643f18e * refactor(search): emit object (#683) 46c7d7d * refactor(searchForFacetValues): use object vs list of arguments (#684) ab8e9c5 * refactor: remove getQueryParameter (#713) d9dfac4 * refactor(searchOnce): use object vs list of arguments (#681) 42b40d3 * refactor(SearchParameters): removes default values (#670) b15696b * refactor(url): remove url helpers (#652) 52e22f4 * test(sffv): no longer test impossible responses (#686) fd878e8 ### BREAKING CHANGE * getState(filters) is replaced my manually filtering the returned object * removed helper.isRefined, use helper.hasRefinements instead * SearchParameters.filter is removed * doc(filter): remove reference * use helper.state instead of helper.getState()

…/algoliasearch-helper-js#718) * Revert "refactor(lodash): intersection (algolia/algoliasearch-helper-js#696)" This reverts commit 4b850471e2488162a27f3eeb86994165a5363476. * fix(lodash/intersection): replace with custom implementation

tkrugg added 2 commits June 21, 2019 16:26

Revert "refactor(lodash): intersection (#696)"

c73ee11

This reverts commit 04b21b4.

fix(lodash/intersection): replace with custom implementation

2d00352

tkrugg force-pushed the next-intersection branch from 10b35a4 to 2d00352 Compare June 21, 2019 14:30

tkrugg marked this pull request as ready for review June 21, 2019 14:58

tkrugg requested review from samouss and a team June 21, 2019 14:59

ghost requested review from francoischalifour and removed request for a team June 21, 2019 15:00

tkrugg requested review from yannickcr and removed request for francoischalifour June 21, 2019 15:26

samouss reviewed Jun 24, 2019

View reviewed changes

src/SearchParameters/index.js Show resolved Hide resolved

Haroenv approved these changes Jun 24, 2019

View reviewed changes

samouss approved these changes Jun 24, 2019

View reviewed changes

tkrugg merged commit 690e130 into next Jun 24, 2019

tkrugg deleted the next-intersection branch June 24, 2019 15:28

Haroenv pushed a commit that referenced this pull request Nov 18, 2019

fix(lodash/intersection): replace with custom implementation (#718)

00dfb4e

* Revert "refactor(lodash): intersection (#696)" This reverts commit 04b21b4. * fix(lodash/intersection): replace with custom implementation

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(lodash/intersection): replace with custom implementation #718

fix(lodash/intersection): replace with custom implementation #718

tkrugg commented Jun 21, 2019

Haroenv commented Jun 24, 2019

samouss commented Jun 24, 2019 •

edited

Loading

Haroenv commented Jun 24, 2019

Haroenv left a comment

fix(lodash/intersection): replace with custom implementation #718

fix(lodash/intersection): replace with custom implementation #718

Conversation

tkrugg commented Jun 21, 2019

Haroenv commented Jun 24, 2019

samouss commented Jun 24, 2019 • edited Loading

Haroenv commented Jun 24, 2019

Haroenv left a comment

Choose a reason for hiding this comment

samouss commented Jun 24, 2019 •

edited

Loading