refactor(lodash): remove reduce (#678)

algolia · Nov 18, 2019 · 7907805 · 7907805
1 parent 8c93765
commit 7907805
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/src/SearchParameters/RefinementList.js b/src/SearchParameters/RefinementList.js
@@ -17,7 +17,6 @@ var isFunction = require('lodash/isFunction');
 var isEmpty = require('lodash/isEmpty');
 var defaults = require('lodash/defaults');
 
-var reduce = require('lodash/reduce');
 var filter = require('lodash/filter');
 var omit = require('../functions/omit');
 
@@ -103,7 +102,8 @@ var lib = {
     } else if (isFunction(attribute)) {
       var hasChanged = false;
 
-      var newRefinementList = reduce(refinementList, function(memo, values, key) {
+      var newRefinementList = Object.keys(refinementList).reduce(function(memo, key) {
+        var values = refinementList[key];
         var facetList = filter(values, function(value) {
           return !attribute(value, key, refinementType);
         });

diff --git a/src/SearchParameters/index.js b/src/SearchParameters/index.js
@@ -4,7 +4,6 @@ var keys = require('lodash/keys');
 var intersection = require('lodash/intersection');
 var forOwn = require('lodash/forOwn');
 var filter = require('lodash/filter');
-var reduce = require('lodash/reduce');
 var isNaN = require('lodash/isNaN');
 var isEmpty = require('lodash/isEmpty');
 var isEqual = require('lodash/isEqual');
@@ -901,7 +900,9 @@ SearchParameters.prototype = {
       return omit(this.numericRefinements, attribute);
     } else if (isFunction(attribute)) {
       var hasChanged = false;
-      var newNumericRefinements = reduce(this.numericRefinements, function(memo, operators, key) {
+      var numericRefinements = this.numericRefinements;
+      var newNumericRefinements = Object.keys(numericRefinements).reduce(function(memo, key) {
+        var operators = numericRefinements[key];
         var operatorList = {};
 
         operators = operators || {};

diff --git a/src/requestBuilder.js b/src/requestBuilder.js
@@ -1,6 +1,5 @@
 'use strict';
 
-var reduce = require('lodash/reduce');
 var merge = require('lodash/merge');
 
 var requestBuilder = {
@@ -261,8 +260,7 @@ var requestBuilder = {
   _getHitsHierarchicalFacetsAttributes: function(state) {
     var out = [];
 
-    return reduce(
-      state.hierarchicalFacets,
+    return state.hierarchicalFacets.reduce(
       // ask for as much levels as there's hierarchical refinements
       function getHitsAttributesForHierarchicalFacet(allAttributes, hierarchicalFacet) {
         var hierarchicalRefinement = state.getHierarchicalRefinement(hierarchicalFacet.name)[0];