Missing "exhaustive" on the hierarchical refinements #258

Jerska · 2015-11-26T16:02:52Z

Hierarchical refinements embed the same kind of information as the other ones, except the exhaustive attribute. It would probably make sense to also add it.

The text was updated successfully, but these errors were encountered:

bobylito · 2015-11-27T08:07:50Z

So adding exhaustive on hierarchicalFacets items? Why not, I like consistency :). Would there be any problems to have an accurate values @vvo @redox ?

vvo · 2015-11-30T15:41:46Z

I do not follow what is the exhaustive attribute, can you precise?

Jerska · 2015-11-30T15:50:22Z

The fact that the counts of the values are exact.

vvo · 2015-11-30T15:50:49Z

So it is a flag to indicate that the count is exact, WFM

correct "exhaustive" fixes #258 keep "path" as name; even if it's a bug

* chore(deps): update dependency algolia-frontend-components to v0.0.35 (#605) 41043af * chore(deps): update dependency algoliasearch to v3.32.0 (#628) e5cab52 * chore(deps): update dependency babel-core to v6.26.3 (#581) 051075c * chore(deps): update dependency browserify to v14.5.0 (#582) 66e2a79 * chore(deps): update dependency handlebars to v4.1.0 (#589) bf1c493 * chore(deps): update dependency http-server to v0.11.1 (#590) 673ee5f * chore(deps): update dependency mversion to v1.13.0 (#630) 1304f19 * chore(deps): update dependency rimraf to v2.6.3 (#596) 5e17830 * chore: use only yarn (no more npm 👩‍🚒) (#637) dba85a0 * chore(deps): update st (#625) 5d7d915 * chore(docs): change jade to pug (#615) 80a20dc, closes #613 * chore(docs): fix interpolation dd888f2 * chore(docs): remove folder in (#616) 7bfc971 * docs(init): use toggleFacetRefinement instead (#622) 2461ffe * docs(instantiate): use existing signature of toggleRefine (#621) 6be5ec1 * docs: fix InstantSearch link (#640) 2c97a71, closes #640 * docs: fix typo on hierarchical facets (#646) ee5b3b4, closes #646 * feat(sffv): throw an error if it's called and the client doesn't have the functions (#623) dd61360 * fix(results): remove lodash looping over objects (#648) c1f540f, closes #258 * fix(ua): change the User-Agent to use the new specs lib (version) (#647) eafd4cf * refactor(events): replace util.inherits by inline (#653) 16459ae * test(client): update index name (#619) 3564274 * Update README.md ace477e

* fix(lodash): remove collection methods done: sumBy, map, find (except one occurence) todo: includes, orderBy * fix(getHierarchicalRefinement): deal correctly with no default separator * finished migration got rid of lodash/get globally! * test(results): add test for facet values * chore(lodash): remove trivial usage of map * chore(results): remove indexOf * chore(lodash): migrate filterState * chore(lodash): remove reduce in formatSort * test(helper): add failing test case for helper having .length value * fix(hierarchical): fix "length" bug (and simplify in the meantime) * chore: fix ran tests * chore(results): remove lodash.includes * refactor(lodash): remove isString & indexOf (34.9kB) * apply feedback from review * fixes on hierarchical correct "exhaustive" fixes #258 keep "path" as name; even if it's a bug * chore: remove comment * Revert "fixes on hierarchical" This reverts commit 042f722. * undo hierarchical changes * chore: undo more fixes * chore: remove dumb comment lol * feedback from review * fix(hierarchical): add exhaustive & lodash looping (#651) * Revert "Revert "fixes on hierarchical"" This reverts commit abfea91. * Revert "undo hierarchical changes" This reverts commit a50a8ae. * Revert "chore: undo more fixes" This reverts commit 78d06c2. * Revert "chore: remove dumb comment lol" This reverts commit 8054352. * feedback from review * chore(test): fix integration

* fix(merge): change implementation (#716) 29c2138 * chore: mention remaining changes f756947 * chore(deps): update circleci/node:8.15.1 docker digest to ef1a0c4 (#715) f4dab89 * chore(lodash): remove _.omit (#655) 7db8b4c * chore(lodash): remove lodash from dependency list (#705) a63ec6b, closes #552 * chore(release): allow canary release (#712) 3eb087c * chore(removeHierarchicalFacetRefinement): remove error if not refined (#747) e68ecfe * chore: merge develop into master (#750) 53c7c62 * chore: remove Bower support (#711) e7518e2 * chore(ts): add methods d051f79 * chore(ts): add ruleContexts to SP 4bdc4a4 * chore(ts): add searchOnlyWithDerivedHelpers (#739) c6aa31b * chore(ts): publish definition file too 1813462 * chore(TS): isNumericRefined has only one required argument cac8fc3 * chore(warn): remove unused function (lodash.bind) (#682) c59b7e3 * chore: update release command 0989880 * docs: add link to wiki 3598f2a * docs: update event signature (#701) bbe4634 * docs(migration): mention changed methods (#732) f95e680 * docs(next): add migration guide 8430137 * docs(serverUsed): mention getRankingInfo (#706) f258c2a, closes #500 * feat: implement dedicated reset page method (#673) 666501e * feat(getState): remove filter option (#707) ac52791 * feat(getState): remove getState (#708) 7de698c * feat(requestBuilder): prevent needless extra requests for empty refinements (#737) db0a392 * feat(search): allow the search only with Derived Helpers (#704) aa128fc * feat(SearchParameters): avoid undefined values (#703) 9757e0a * feat(typescript): move typings inline (#719) a12272e * fix(defaults): remove const 48a0c48 * fix(errors): remove isRefined (#731) 5761885 * fix(getConjunctiveRefinements): no error when requested facet is not conjunctive (#724) cf852e7 * fix(getDisjunctiveRefinements): remove error (#725) 211e390 * fix(getExcludeRefinements): replace error by default value (#726) 9d7ae87 * fix(getFacetStats): remove error (#721) 96b6ec8 * fix(getFacetValues): don't throw error when there's no facet (#720) e15e39e * fix(getHierarchicalFacetBreadcrumb): don't throw an error (#723) 40e1d61 * fix(isDisjunctiveFacetRefined): return false if not in disjunctiveFacets (#729) 13ec09b * fix(isExcludeRefined): remove error in favor of false (#728) 3f0ab6b * fix(isFacetRefined): return false if facet isn't declared (#727) 7151f56 * fix(isHierarchicalFacetRefined): return false if refinement isn't a facet (#730) 89fa010 * fix(lodash/intersection): replace with custom implementation (#718) 00dfb4e * fix(removeXFacet): make sure this fully removes empty arrays (#743) ea5a22a * fix(results): remove lodash looping over objects (#648) bb025c2, closes #258 * fix(sortBy): compare whole prefix instead of first character (#702) b85fb50, closes #702 * fix(toggleRefinement): keep an empty array when clearing (#738) 5b3fc11 * fix(types): add state.removeNumericRefinement (#742) e58c24a * refactor(addAgent): remove duplicate code (#657) d023efd * refactor(error): use object vs list of arguments (#700) 722eceb * refactor(lodash): compact (#689) 284efa5 * refactor(lodash): forOwn (#697) eae367a * refactor(lodash): intersection (#696) 25822a5 * refactor(lodash): map & trim (#679) 357fcb7 * refactor(lodash): merge (#694) 92bced4 * refactor(lodash): partial & partialRight (#693) 7ceea2f * refactor(lodash): remove filter (#685) 249d2e6 * refactor(lodash): remove flatten (#695) 9da0e08 * refactor(lodash): remove forEach (#674) 8c93765 * refactor(lodash): remove reduce (#678) 7907805 * refactor(lodash): remove simple functions (#656) c309ffa * refactor(lodash): remove startsWith (#690) bb00933 * refactor(lodash): replace defaults with pure alternative (#692) ee07132 * refactor(lodash): replace find & findIndex (#687) 92e7c23 * refactor(lodash): replace orderBy (#698) bb2b31e * refactor(lodash): sumBy (#688) a538bd9 * refactor(result): use object vs list of arguments (#699) 643f18e * refactor(search): emit object (#683) 46c7d7d * refactor(searchForFacetValues): use object vs list of arguments (#684) ab8e9c5 * refactor: remove getQueryParameter (#713) d9dfac4 * refactor(searchOnce): use object vs list of arguments (#681) 42b40d3 * refactor(SearchParameters): removes default values (#670) b15696b * refactor(url): remove url helpers (#652) 52e22f4 * test(sffv): no longer test impossible responses (#686) fd878e8 ### BREAKING CHANGE * getState(filters) is replaced my manually filtering the returned object * removed helper.isRefined, use helper.hasRefinements instead * SearchParameters.filter is removed * doc(filter): remove reference * use helper.state instead of helper.getState()

…ch-helper-js#648) * fix(lodash): remove collection methods done: sumBy, map, find (except one occurence) todo: includes, orderBy * fix(getHierarchicalRefinement): deal correctly with no default separator * finished migration got rid of lodash/get globally! * test(results): add test for facet values * chore(lodash): remove trivial usage of map * chore(results): remove indexOf * chore(lodash): migrate filterState * chore(lodash): remove reduce in formatSort * test(helper): add failing test case for helper having .length value * fix(hierarchical): fix "length" bug (and simplify in the meantime) * chore: fix ran tests * chore(results): remove lodash.includes * refactor(lodash): remove isString & indexOf (34.9kB) * apply feedback from review * fixes on hierarchical correct "exhaustive" fixes algolia/algoliasearch-helper-js#258 keep "path" as name; even if it's a bug * chore: remove comment * Revert "fixes on hierarchical" This reverts commit 042f7220c500e4f397b2da03f4fffb44f8ab47a3. * undo hierarchical changes * chore: undo more fixes * chore: remove dumb comment lol * feedback from review * fix(hierarchical): add exhaustive & lodash looping (algolia/algoliasearch-helper-js#651) * Revert "Revert "fixes on hierarchical"" This reverts commit abfea9177e300207636c5cbd48ddc21b8213137a. * Revert "undo hierarchical changes" This reverts commit a50a8ae00cafa4373a35612795f378d6b33e1892. * Revert "chore: undo more fixes" This reverts commit 78d06c21d65396a13d23443cd0ce7dc612bb332e. * Revert "chore: remove dumb comment lol" This reverts commit 8054352042a47f27ab66f56ccf3a347787c86888. * feedback from review * chore(test): fix integration

Jerska added enhancement labels Nov 26, 2015

bobylito added Type: Question Type: Feature and removed question labels Jun 8, 2017

Haroenv added a commit that referenced this issue Apr 5, 2019

fixes on hierarchical

042f722

correct "exhaustive" fixes #258 keep "path" as name; even if it's a bug

Haroenv closed this as completed in c1f540f Apr 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Missing "exhaustive" on the hierarchical refinements #258

Missing "exhaustive" on the hierarchical refinements #258

Jerska commented Nov 26, 2015

bobylito commented Nov 27, 2015

vvo commented Nov 30, 2015

Jerska commented Nov 30, 2015

vvo commented Nov 30, 2015

Missing "exhaustive" on the hierarchical refinements #258

Missing "exhaustive" on the hierarchical refinements #258

Comments

Jerska commented Nov 26, 2015

bobylito commented Nov 27, 2015

vvo commented Nov 30, 2015

Jerska commented Nov 30, 2015

vvo commented Nov 30, 2015