-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add many_calls tests to EXECUTING_SLOW_TESTS #78
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it'd be better to skip this test unless EXECUTING_SLOW_TESTS is on. |
matoro
changed the title
Relax many_calls tests further
Add many_calls tests to EXECUTING_SLOW_TESTS
Nov 6, 2023
Switched to this and retitled PR. |
great, thanks! |
matoro
added a commit
to matoro/gentoo
that referenced
this pull request
Nov 6, 2023
The original skips are technically for tests that take a long time to run, which these aren't really - they just fail if run under a sufficiently slow CPU since they are measuring a hard real-time benchmark. Already accepted upstream. See: alexmojaki/executing#78 Bug: https://bugs.gentoo.org/909738 Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
matoro
added a commit
to matoro/gentoo
that referenced
this pull request
Nov 7, 2023
The original skips are technically for tests that take a long time to run, which these aren't really - they just fail if run under a sufficiently slow CPU since they are measuring a hard real-time benchmark. Already accepted upstream. See: alexmojaki/executing#78 Bug: https://bugs.gentoo.org/909738 Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
matoro
added a commit
to matoro/gentoo
that referenced
this pull request
Nov 7, 2023
The original skips are technically for tests that take a long time to run, which these aren't really - they just fail if run under a sufficiently slow CPU since they are measuring a hard real-time benchmark. Already accepted upstream. See: alexmojaki/executing#78 Bug: https://bugs.gentoo.org/909738 Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
matoro
added a commit
to matoro/gentoo
that referenced
this pull request
Nov 7, 2023
The original skips are technically for tests that take a long time to run, which these aren't really - they just fail if run under a sufficiently slow CPU since they are measuring a hard real-time benchmark. Already accepted upstream. See: alexmojaki/executing#78 Bug: https://bugs.gentoo.org/909738 Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Nov 7, 2023
The original skips are technically for tests that take a long time to run, which these aren't really - they just fail if run under a sufficiently slow CPU since they are measuring a hard real-time benchmark. Already accepted upstream. See: alexmojaki/executing#78 Bug: https://bugs.gentoo.org/909738 Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk> Signed-off-by: Sam James <sam@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still fails on slow CPU.