Added check when diplomatic relations change with players. #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a condition that prevented fleets attacking other fleets. Removed some leftover debug messages.
|
New bug #1143 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check when diplomatic relations change with players.
Now this is only used for stopping fleets mid attack. The function checks if relations improved and if the value is above the Player object's new threshold value "endHostilitiesThreshold". The higher of the two opposing sides' is taken into account.
Fixed a condition that prevented fleets from attacking other fleets.
Removed some leftover debug messages.
Should resolve #1135