-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to attack traders, v0.95.246 #1143
Comments
This is what cancels the attack:
|
Tested this on v0.95.246 with #1142 . I was unable to reproduce it with the fix in that PR. Unfortunately I only submitted it after the release of v0.95.246 . Turns out the fix wasn't so minor after all... On that topic stopping player fleets also when diplomatic relations improve was an intended effect, though it might be better to put that behind a configuration. |
Traders started out with 50 and then bumped to 100 by some initialization, which triggered the stopping of all player fleets because passing the threshold.
No need for config. Put that on a code path that is only triggered by the change in the diplomatic stance from the Diplomacy screen. |
Reported on Facebook. Confirmed locally.
Starting a new campaign and attacking the traders does not start a spacewar.
In fact, the attack gets cancelled several times within a few seconds if the trader is away. If my fleet is within range, when the trader is reached, nothing happens.
The text was updated successfully, but these errors were encountered: