-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR #9407/e653b281 backport][3.11] Add __slots__ to stream classes #9408
[PR #9407/e653b281 backport][3.11] Add __slots__ to stream classes #9408
Conversation
(cherry picked from commit e653b28)
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 3.11 #9408 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 108 108
Lines 35142 35144 +2
Branches 4194 4194
=======================================
+ Hits 34373 34375 +2
Misses 573 573
Partials 196 196
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Looks like 3.11 has another set outside of init |
This is a backport of PR #9407 as merged into master (e653b28).
What do these changes do?
We use
__slots__
almost everywhere else in the codebase, however__slots__
were not implemented in streamrelated issue #4618 (comment)
Are there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no