Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9407/e653b281 backport][3.11] Add __slots__ to stream classes #9408

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Oct 3, 2024

This is a backport of PR #9407 as merged into master (e653b28).

What do these changes do?

We use __slots__ almost everywhere else in the codebase, however __slots__ were not implemented in stream

related issue #4618 (comment)

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.81%. Comparing base (4c67472) to head (c32ebfc).
Report is 3 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11    #9408   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files         108      108           
  Lines       35142    35144    +2     
  Branches     4194     4194           
=======================================
+ Hits        34373    34375    +2     
  Misses        573      573           
  Partials      196      196           
Flag Coverage Δ
CI-GHA 97.68% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.37% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.88% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.07% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.93% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 96.86% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 96.95% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.01% <100.00%> (+<0.01%) ⬆️
Py-3.12.6 97.41% <100.00%> (+<0.01%) ⬆️
Py-3.13.0-rc.3 97.39% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.84% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 96.78% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.39% <100.00%> (+<0.01%) ⬆️
VM-macos 97.07% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.37% <100.00%> (+<0.01%) ⬆️
VM-windows 94.88% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco
Copy link
Member

bdraco commented Oct 3, 2024

Looks like 3.11 has another set outside of init

@bdraco bdraco marked this pull request as draft October 3, 2024 22:18
@bdraco bdraco marked this pull request as ready for review October 3, 2024 22:58
@bdraco bdraco merged commit 0dbfa7f into 3.11 Oct 3, 2024
34 of 35 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/e653b2810f0a159618499ac3ae0c5c0d8afb1317/pr-9407 branch October 3, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant