Add __slots__ to stream classes #9407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use `__slots__` almost everywhere else in the codebase, however `__slots__` were not implemented in stream related issue #4618
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9407 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 107 107
Lines 35037 35043 +6
Branches 4150 4150
=======================================
+ Hits 34536 34542 +6
Misses 334 334
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
added
the
backport-3.11
|
Probably should not backport to 3.10 just in case someone is doing some interesting subclassing |
bdraco
commented
Oct 3, 2024
psf-chronographer
bot
added
the
bot:chronographer:provided
Dreamsorcerer
approved these changes
Oct 3, 2024
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9408 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
(cherry picked from commit e653b28)
bdraco
added a commit
that referenced
this pull request
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
We use
__slots__almost everywhere else in the codebase, however__slots__were not implemented in streamrelated issue #4618 (comment)
Are there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no