Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Mac OS support. Updated README. #19

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

colossatr0n
Copy link

@colossatr0n colossatr0n commented Sep 22, 2021

Added Mac OS support and updated README. This is in reference to #18.

The build scripts for Mac require that the VLC dylibs be put in the LLG-MP app's Framework directory. This is because of an issue with WebChimera.

Also, I removed some of the path creation logic in app.js related to the newVocab due to incompatibility with forward slashes vs backslashes. Not sure if it'll break things for the Windows build or not. -> fixed this with commit b4ec8a4

The majority of the files added in this PR are for the VLC Mac plugins.

Here's a preview of the table added to the README:

image

…ing and distributing for Mac. Also changed "-" to ":" just because its standard practice for package.json scripts.
…libs are moved into the Frameworks folder during the mac build. Using NPM to do this for the dist folder will invalidate the code sign, hence the change.
@ahmedmaher05 ahmedmaher05 added this to In Test in LLG-MP Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
LLG-MP
  
In Test
Development

Successfully merging this pull request may close these issues.

None yet

1 participant