Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac OS support #18

Open
colossatr0n opened this issue Sep 20, 2021 · 5 comments
Open

Mac OS support #18

colossatr0n opened this issue Sep 20, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@colossatr0n
Copy link

Just putting in an enhancement request to add Mac OS support.

Since this is an electron-app, what exactly does this conversion entail? Does the actual logic of LLG-MP need to be changed, or is it mostly build and dependency stuff?

@colossatr0n
Copy link
Author

colossatr0n commented Sep 21, 2021

I actually started working on a feature branch and have it running now. I'll see if I can flesh out the rest of the branch and then I'll submit a PR for Mac OS support.

@ahmedmaher05
Copy link
Owner

No major stuff, Mostly dependencies indeed.

great job @colossatr0n , the merge works successfully but has some minor conflicts with regression testing for some other features. kindly provide your email/skype or join the Gitter chat link in the README.md section if you are free to give me a hand in solving the regression test issues together. nevertheless, I will work on it ASAP if you were busy.

@colossatr0n
Copy link
Author

Thank you! I just joined the Gitter chatroom.

@ahmedmaher05
Copy link
Owner

ahmedmaher05 commented Sep 23, 2021

Great, gonna catch up with you there in a while

@colossatr0n
Copy link
Author

Fixed some more issues with the PR. Hopefully that'll resolve some of those regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants