You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request adds a new FileSystem API that replaces NativeFileSystem, FileIndexManager and direct calls to brackets.fs.* functions.
This pull request changes the API, but does not add any significant new features or performance gains. These will be done in subsequent pull requests.
This is a big change. It will break some extensions. However, the breakages are minimized through deprecation "shims" for many of the commonly used APIs that have been removed.
The reason will be displayed to describe this comment to others. Learn more.
@iwehrman I'd rather us not do a catch-and-log if we don't need to, since it breaks the debugger "break on uncaught exceptions" feature. In this case it seems unneeded since the only thing that comes afterward is in a finally block anyway.
The reason will be displayed to describe this comment to others. Learn more.
I forgot about the "break on uncaught exceptions" use case. I'll change all these try-catch-finally blocks in which the catch only contains a console.warn to just try-finally blocks.
Sorry for adding a bunch of comments saying I was fixing stuff that's already been fixed... dunno how I got so far out of sync from the tip of the branch. One of my git fetches must have filed without me noticing the error message, or something.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new FileSystem API that replaces
NativeFileSystem,FileIndexManagerand direct calls tobrackets.fs.*functions.This pull request changes the API, but does not add any significant new features or performance gains. These will be done in subsequent pull requests.
This is a big change. It will break some extensions. However, the breakages are minimized through deprecation "shims" for many of the commonly used APIs that have been removed.
See this Brackets-Dev forum thread for an introduction to the changes.
See the FileSystem and FileSystem API Migration wiki pages for more details.
Sign-offs: