Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

New FileSystem API #5797

Merged
merged 206 commits into from
Nov 8, 2013
Merged

New FileSystem API #5797

merged 206 commits into from
Nov 8, 2013

Commits on Jun 28, 2013

  1. Configuration menu
    Copy the full SHA
    f73b6ed View commit details
    Browse the repository at this point in the history
  2. Add FileIndex

    gruehle committed Jun 28, 2013
    Configuration menu
    Copy the full SHA
    26c31d3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4a4471c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    619dd45 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    714732b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1fa9144 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cb6b986 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5fcf425 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2013

  1. Configuration menu
    Copy the full SHA
    bf68b86 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    868e45b View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2013

  1. Reorganize impl files

    gruehle committed Jul 2, 2013
    Configuration menu
    Copy the full SHA
    13368c4 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2013

  1. Configuration menu
    Copy the full SHA
    8a56cee View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2013

  1. Configuration menu
    Copy the full SHA
    045f346 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6be82be View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    89d1dbc View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2013

  1. Configuration menu
    Copy the full SHA
    543e122 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2013

  1. Configuration menu
    Copy the full SHA
    0089986 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2013

  1. Configuration menu
    Copy the full SHA
    848e0b6 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2013

  1. Configuration menu
    Copy the full SHA
    819a208 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2013

  1. Merge with master

    gruehle committed Aug 14, 2013
    Configuration menu
    Copy the full SHA
    65f69aa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ba93b48 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    45899bb View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2013

  1. Unit tests

    gruehle committed Aug 16, 2013
    Configuration menu
    Copy the full SHA
    c89ae3f View commit details
    Browse the repository at this point in the history
  2. Cleanup

    gruehle committed Aug 16, 2013
    Configuration menu
    Copy the full SHA
    ce74bc8 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2013

  1. Minor cleanup

    gruehle committed Sep 11, 2013
    Configuration menu
    Copy the full SHA
    eaca879 View commit details
    Browse the repository at this point in the history
  2. Merge with master

    gruehle committed Sep 11, 2013
    Configuration menu
    Copy the full SHA
    ada68e2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    490ce52 View commit details
    Browse the repository at this point in the history
  4. Submodule updates

    gruehle committed Sep 11, 2013
    Configuration menu
    Copy the full SHA
    1cacf78 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2013

  1. Fix CSSCodeHints unit tests

    gruehle committed Sep 12, 2013
    Configuration menu
    Copy the full SHA
    1c1fb62 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2013

  1. Configuration menu
    Copy the full SHA
    3cdcfb4 View commit details
    Browse the repository at this point in the history
  2. Do not stat an untitled document's underlying file

    Ian Wehrman committed Sep 13, 2013
    Configuration menu
    Copy the full SHA
    6a9b2d0 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'brackets' into glenn/file-system

    Conflicts:
    	test/spec/SpecRunnerUtils.js
    Ian Wehrman committed Sep 13, 2013
    Configuration menu
    Copy the full SHA
    0d2b8d5 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2013

  1. ProjectManager.renameItem work-in-progress

    Ian Wehrman committed Sep 14, 2013
    Configuration menu
    Copy the full SHA
    d5f3259 View commit details
    Browse the repository at this point in the history
  2. Add a question comment so I don't forget about it

    Ian Wehrman committed Sep 14, 2013
    Configuration menu
    Copy the full SHA
    599755c View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2013

  1. Add another question

    Ian Wehrman committed Sep 16, 2013
    Configuration menu
    Copy the full SHA
    b252859 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'brackets' into glenn/file-system

    Conflicts:
    	src/search/FindInFiles.js
    Ian Wehrman committed Sep 16, 2013
    Configuration menu
    Copy the full SHA
    b124d1b View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2013

  1. Revert comments for cleanliness in the public branch

    Ian Wehrman committed Sep 17, 2013
    Configuration menu
    Copy the full SHA
    d93a85e View commit details
    Browse the repository at this point in the history
  2. Fix a watcherCallback bug

    Ian Wehrman committed Sep 17, 2013
    Configuration menu
    Copy the full SHA
    5237004 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'glenn/file-system' of https://github.com/adobe/brackets

    …into glenn/file-system
    gruehle committed Sep 17, 2013
    Configuration menu
    Copy the full SHA
    4d362dd View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2013

  1. fix the isDirectory test in handleFileDelete

    Ian Wehrman committed Sep 18, 2013
    Configuration menu
    Copy the full SHA
    3035dca View commit details
    Browse the repository at this point in the history
  2. Remove a vestigial variable in renameItem

    Ian Wehrman committed Sep 18, 2013
    Configuration menu
    Copy the full SHA
    6df65b9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b5248bf View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2013

  1. Configuration menu
    Copy the full SHA
    daec4a2 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2013

  1. Silently ignore directory entries without stats.

    Ian Wehrman committed Sep 23, 2013
    Configuration menu
    Copy the full SHA
    b10bb35 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'brackets' into glenn/file-system

    Conflicts:
    	test/spec/SpecRunnerUtils.js
    Ian Wehrman committed Sep 23, 2013
    Configuration menu
    Copy the full SHA
    2640846 View commit details
    Browse the repository at this point in the history
  3. Yes, FileIndex.getAllFiles really should always return a copy of the …

    …array
    Ian Wehrman committed Sep 23, 2013
    Configuration menu
    Copy the full SHA
    e0e4f4d View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2013

  1. Merge branch 'brackets' into glenn/file-system

    Ian Wehrman committed Sep 24, 2013
    Configuration menu
    Copy the full SHA
    da95b3a View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2013

  1. Merge branch 'brackets' into glenn/file-system

    Ian Wehrman committed Oct 1, 2013
    Configuration menu
    Copy the full SHA
    e8be7c0 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2013

  1. Change FileSystemManager.createFileSystem() to be async -- allowing

    filesystem impls time to seed any required initial data, or go through
    authentication workflows.
    peterflynn committed Oct 3, 2013
    Configuration menu
    Copy the full SHA
    b08d0d1 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2013

  1. Configuration menu
    Copy the full SHA
    f451101 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'glenn/file-system' of https://github.com/adobe/brackets

    …into glenn/file-system
    gruehle committed Oct 4, 2013
    Configuration menu
    Copy the full SHA
    5352487 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2013

  1. Configuration menu
    Copy the full SHA
    b1ad00c View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2013

  1. Fix new file (in project).

    gruehle committed Oct 7, 2013
    Configuration menu
    Copy the full SHA
    8705bbb View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2013

  1. Add error codes.

    gruehle committed Oct 8, 2013
    Configuration menu
    Copy the full SHA
    29ad888 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a3b5e70 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    88283d9 View commit details
    Browse the repository at this point in the history
  4. Fix file watching

    gruehle committed Oct 8, 2013
    Configuration menu
    Copy the full SHA
    9ffe75f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    996ea0d View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2013

  1. Use DocumentManager.getDocumentForPath() for find in files. Commented…

    … out for now since it is 3x slower.
    gruehle committed Oct 9, 2013
    Configuration menu
    Copy the full SHA
    d0cb127 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fb2c451 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8269ff1 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2013

  1. Standardize back on trailing-/ for directory paths. This is safer for…

    … legacy
    
    code that concats paths with this assumption. The normalization hook in
    FileSystem also removes duplicated /es. In the future it could also handle
    "/." and "/..", but it doesn't yet.
    
    Fixes the infinite-traversal bug in JS code hints & re-enables the unit
    tests that were hitting it. But adds some hacky temp code to forestall race
    conditions when running these tests (presumably a race on master too).
    
    Many of the diffs are just restoring code back to what it is on master.
    peterflynn committed Oct 11, 2013
    Configuration menu
    Copy the full SHA
    af57cff View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    087a451 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9dc6a18 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'glenn/file-system' of https://github.com/adobe/brackets

    …into glenn/file-system
    gruehle committed Oct 11, 2013
    Configuration menu
    Copy the full SHA
    5d8394d View commit details
    Browse the repository at this point in the history
  5. Move InMemoryFile out of filesystem. It is now a Brackets-specific de…

    …tail
    
    used as a placeholder by DocumentManager (though still a File subclass).
    Like the setup on master, the filesystem APIs will all act like they don't
    know anything about this 'file'.
    
    Also: log warnings when FileSystem receives path with "." or ".." segments.
    peterflynn committed Oct 11, 2013
    Configuration menu
    Copy the full SHA
    c5d15eb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c5bafcf View commit details
    Browse the repository at this point in the history
  7. Merge branch 'glenn/file-system' of https://github.com/adobe/brackets

    …into glenn/file-system
    gruehle committed Oct 11, 2013
    Configuration menu
    Copy the full SHA
    af80be7 View commit details
    Browse the repository at this point in the history
  8. Fix JSLint error.

    gruehle committed Oct 11, 2013
    Configuration menu
    Copy the full SHA
    6f01dfe View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    333bb13 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2013

  1. Configuration menu
    Copy the full SHA
    8050678 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2013

  1. Add ProjectManager.getAllFiles(), replacing FileSystem.getFileList().…

    … Purge the _allFiles handling from FileIndex.
    gruehle committed Oct 13, 2013
    Configuration menu
    Copy the full SHA
    89945f8 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2013

  1. Add FileSystem.watch and FileSystem.unwatch; remove FileSystem._scanD…

    …irectory and FileSystem.setProjectRoot
    Ian Wehrman committed Oct 14, 2013
    Configuration menu
    Copy the full SHA
    266cdaa View commit details
    Browse the repository at this point in the history
  2. Serialize watch/unwatch requests

    Ian Wehrman committed Oct 14, 2013
    Configuration menu
    Copy the full SHA
    b060e8f View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2013

  1. Do not unwatch after a failed watch attempt

    Ian Wehrman committed Oct 15, 2013
    Configuration menu
    Copy the full SHA
    94f3f4d View commit details
    Browse the repository at this point in the history
  2. * Normalize out ".."s in paths

    * Assert that we're never getting relative paths
    * Fix bug in duplicated-"/" normalization
    * Add unit tests for path normalization
    peterflynn committed Oct 15, 2013
    Configuration menu
    Copy the full SHA
    444fbb0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    93a276c View commit details
    Browse the repository at this point in the history
  4. Do not create multiple FSWatchers for the same path

    Ian Wehrman committed Oct 15, 2013
    Configuration menu
    Copy the full SHA
    53992af View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2013

  1. Configuration menu
    Copy the full SHA
    a91c32c View commit details
    Browse the repository at this point in the history
  2. TODO cleanups

    gruehle committed Oct 16, 2013
    Configuration menu
    Copy the full SHA
    ca5820f View commit details
    Browse the repository at this point in the history
  3. Fix *file* watching on Windows: normalize out doubled "/"es in paths

    received from Node-side watcher impl
    peterflynn committed Oct 16, 2013
    Configuration menu
    Copy the full SHA
    1d815b9 View commit details
    Browse the repository at this point in the history
  4. Ensure the callbacks for write operations (including their index fixups)

    run before any file-watcher callbacks caused by that operation. This
    prevents race condition bugs, e.g. files saved to disk might appear to be
    conflicting changes, or renames might be treated as a delete-add pair without
    fixing up the index more cleanly.
    
    Also:
    - add helpful toString() for File/Directory objects
    - clarify FileSystemEntry.rename() argument
    peterflynn committed Oct 16, 2013
    Configuration menu
    Copy the full SHA
    f5e8269 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    466e044 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2013

  1. Configuration menu
    Copy the full SHA
    1c8f5a1 View commit details
    Browse the repository at this point in the history
  2. Remove superfluous warning message

    Ian Wehrman committed Oct 17, 2013
    Configuration menu
    Copy the full SHA
    d091932 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    634ab02 View commit details
    Browse the repository at this point in the history
  4. Merge remote-tracking branch 'origin/glenn/file-system' into glenn/fi…

    …le-system
    
    * origin/glenn/file-system:
      Remove superfluous warning message
      Explicitly watch and unwatch directories in breadth-first order
      Make FileIndex.removeEntry a no-op for now.
    peterflynn committed Oct 17, 2013
    Configuration menu
    Copy the full SHA
    9576a8c View commit details
    Browse the repository at this point in the history
  5. Move shouldShow() back onto ProjectManager, and pass it into FileSyst…

    …em as
    
    a client-specific filter function. Share the same filter for both watch()
    and Directory.getContents() - API now reconciled so it always takes a path
    (string), not an entry obj.
    
    Note that FileSystem._indexFilter() has a little more overhead, because it
    has to find the watch-root. I timed this and it only adds a cumulative total
    of 25ms while loading & watch()ing the brackets repo, so it seems manageable.
    
    This does NOT fix the pre-existing issues around items that may be filtered
    out of watching and getContents() but still added to the index anyway via
    explicit getFile/getDirectoryForPath() calls.
    peterflynn committed Oct 17, 2013
    Configuration menu
    Copy the full SHA
    413fe4f View commit details
    Browse the repository at this point in the history
  6. Make FileSystem a singleton.

    gruehle committed Oct 17, 2013
    Configuration menu
    Copy the full SHA
    290da88 View commit details
    Browse the repository at this point in the history
  7. Merge

    gruehle committed Oct 17, 2013
    Configuration menu
    Copy the full SHA
    a29d37b View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2013

  1. Configuration menu
    Copy the full SHA
    931e8d3 View commit details
    Browse the repository at this point in the history
  2. Bump Tern submodule to include a patch for crashing bug caused by the…

    … filesystem code
    Ian Wehrman committed Oct 18, 2013
    Configuration menu
    Copy the full SHA
    e142295 View commit details
    Browse the repository at this point in the history
  3. Catch and handle file watcher errors

    Ian Wehrman committed Oct 18, 2013
    Configuration menu
    Copy the full SHA
    fa0171d View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2013

  1. Add FileSystemEntry.chmod

    Ian Wehrman committed Oct 21, 2013
    Configuration menu
    Copy the full SHA
    eff3422 View commit details
    Browse the repository at this point in the history
  2. Convert SpecRunnerUtils.chmod and SpecRunnerUtils._stat to use FileSy…

    …stemEntry.chmod and FileSystemEntry.stat
    Ian Wehrman committed Oct 21, 2013
    Configuration menu
    Copy the full SHA
    00b315a View commit details
    Browse the repository at this point in the history
  3. Merge branch 'brackets' into glenn/file-system

    Conflicts:
    	src/document/DocumentManager.js
    	src/language/JSUtils.js
    	src/project/ProjectManager.js
    	src/search/FindInFiles.js
    Ian Wehrman committed Oct 21, 2013
    Configuration menu
    Copy the full SHA
    bfb113d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    387eb81 View commit details
    Browse the repository at this point in the history
  5. Fix failing DocumentCommandHandlers tests

    Ian Wehrman committed Oct 21, 2013
    Configuration menu
    Copy the full SHA
    bd967ff View commit details
    Browse the repository at this point in the history
  6. Merge remote-tracking branch 'github/glenn/file-system' into glenn/fi…

    …le-system
    Ian Wehrman committed Oct 21, 2013
    Configuration menu
    Copy the full SHA
    26c792c View commit details
    Browse the repository at this point in the history
  7. Rename filesystem/Error -> filesystem/FileSystemError

    Ian Wehrman committed Oct 21, 2013
    Configuration menu
    Copy the full SHA
    4ab1a60 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2013

  1. Fix submodule SHAs

    Ian Wehrman committed Oct 22, 2013
    Configuration menu
    Copy the full SHA
    0d32066 View commit details
    Browse the repository at this point in the history
  2. Fix rename

    gruehle committed Oct 22, 2013
    Configuration menu
    Copy the full SHA
    5e7bd59 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'glenn/file-system' of https://github.com/adobe/brackets

    …into glenn/file-system
    gruehle committed Oct 22, 2013
    Configuration menu
    Copy the full SHA
    cee12e8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9f2578d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    80fa112 View commit details
    Browse the repository at this point in the history
  6. More efficient way to read text for bulk operations like Find in Files:

    don't construct a full Document if one doesn't exist, but do use the same
    text-normalization code that a full Document would.
    peterflynn committed Oct 22, 2013
    Configuration menu
    Copy the full SHA
    3ad103c View commit details
    Browse the repository at this point in the history
  7. Remove FileSystemEntry objects from the FileIndex upon unwatch, unlin…

    …k or moveToTrash
    Ian Wehrman committed Oct 22, 2013
    Configuration menu
    Copy the full SHA
    8403184 View commit details
    Browse the repository at this point in the history
  8. Merge branch 'glenn/file-system' of https://github.com/adobe/brackets

    …into glenn/file-system
    Ian Wehrman committed Oct 22, 2013
    Configuration menu
    Copy the full SHA
    892a808 View commit details
    Browse the repository at this point in the history
  9. Restore projectRefresh event

    Ian Wehrman committed Oct 22, 2013
    Configuration menu
    Copy the full SHA
    202da51 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    3ba67f5 View commit details
    Browse the repository at this point in the history
  11. Merge branch 'glenn/file-system' of https://github.com/adobe/brackets

    …into glenn/file-system
    gruehle committed Oct 22, 2013
    Configuration menu
    Copy the full SHA
    ec16c64 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2013

  1. Configuration menu
    Copy the full SHA
    7756ce1 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'glenn/file-system' of https://github.com/adobe/brackets

    …into glenn/file-system
    gruehle committed Oct 23, 2013
    Configuration menu
    Copy the full SHA
    654c984 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e2a3a15 View commit details
    Browse the repository at this point in the history
  4. JSDoc additions and cleanup.

    gruehle committed Oct 23, 2013
    Configuration menu
    Copy the full SHA
    276c403 View commit details
    Browse the repository at this point in the history
  5. Fix LanguageManager tests

    Ian Wehrman committed Oct 23, 2013
    Configuration menu
    Copy the full SHA
    89cda23 View commit details
    Browse the repository at this point in the history
  6. Remove dependency on FileIndexManager

    Ian Wehrman committed Oct 23, 2013
    Configuration menu
    Copy the full SHA
    8ae8dc5 View commit details
    Browse the repository at this point in the history
  7. Reintroduce caching for directory contents: we can be less conservati…

    …ve than
    
    file contents because it's less scary to have dir listings be out of date
    (this follows how Brackets master already operates).
    
    Appshell FS now dispatches synthetic change events whenever it modifies /
    creates / destroys items itself - this ensures the dir caches are as up to
    date as possible without real watchers (instead of only clearing caches on
    window focus). This also matches Brackets master, where caches like
    FileIndexManager would be cleared on every "projectFilesChange" event.
    
    Also, fixes a bug where Directory._stat wasn't cleared when watchers said
    the dir changed.
    peterflynn committed Oct 23, 2013
    Configuration menu
    Copy the full SHA
    8fdc8d0 View commit details
    Browse the repository at this point in the history
  8. Merge remote-tracking branch 'origin/glenn/file-system' into glenn/fi…

    …le-system
    
    * origin/glenn/file-system:
      Remove dependency on FileIndexManager
    peterflynn committed Oct 23, 2013
    Configuration menu
    Copy the full SHA
    df26c44 View commit details
    Browse the repository at this point in the history
  9. Fix frequent project tree flickering & scroll pos loss: effectively r…

    …evert
    
    to master's behavior where tree is only refreshed manually by user (it's
    still incrementally updated due to changes within Brackets, but updating to
    pick up external changes - which is always a full, flickery refresh - never
    occurs automatically).
    
    We'll reintroduce auto-tree-refresh once we can bring down the false-
    positive rate for fs change events (once we have real watchers instead of
    just a window-focus listener).
    peterflynn committed Oct 23, 2013
    Configuration menu
    Copy the full SHA
    98954da View commit details
    Browse the repository at this point in the history
  10. Fix a ProjectManager test

    Ian Wehrman committed Oct 23, 2013
    Configuration menu
    Copy the full SHA
    fa70a26 View commit details
    Browse the repository at this point in the history
  11. Re-disable the FileIndexManager tests

    Ian Wehrman committed Oct 23, 2013
    Configuration menu
    Copy the full SHA
    181278c View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2013

  1. Configuration menu
    Copy the full SHA
    e53bbfb View commit details
    Browse the repository at this point in the history
  2. Add more FileSystem unit tests. A new MockFileSystemImpl is used to m…

    …ock the low-level implementation.
    gruehle committed Oct 24, 2013
    Configuration menu
    Copy the full SHA
    955c6d3 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'brackets' into glenn/file-system

    Conflicts:
    	src/document/DocumentCommandHandlers.js
    	src/document/DocumentManager.js
    	src/editor/CSSInlineEditor.js
    	src/file/FileUtils.js
    	src/project/ProjectManager.js
    	test/spec/DocumentCommandHandlers-test.js
    Ian Wehrman committed Oct 24, 2013
    Configuration menu
    Copy the full SHA
    2ab57c0 View commit details
    Browse the repository at this point in the history
  4. Fix the acorn SHA

    Ian Wehrman committed Oct 24, 2013
    Configuration menu
    Copy the full SHA
    63f452e View commit details
    Browse the repository at this point in the history
  5. Remove many instances of brackets.fs usage

    Ian Wehrman committed Oct 24, 2013
    Configuration menu
    Copy the full SHA
    d3e0b2d View commit details
    Browse the repository at this point in the history
  6. Remove unlink callback

    Ian Wehrman committed Oct 24, 2013
    Configuration menu
    Copy the full SHA
    35a6cc0 View commit details
    Browse the repository at this point in the history
  7. Replace NativeFileSystem with FileSystem in ImageViewer

    Ian Wehrman committed Oct 24, 2013
    Configuration menu
    Copy the full SHA
    8c60a81 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a88bbff View commit details
    Browse the repository at this point in the history
  9. - Fix getAllFiles() to exclude isBinaryFile() matches just like old

    FileIndexManager did.
    - Exclude untitled documents when adding working set contents to
    getAllFiles() result, since its clients aren't prepared for that yet.
    - Don't require getAllFiles()'s 'filter' arg to be a strict boolean
    peterflynn committed Oct 24, 2013
    Configuration menu
    Copy the full SHA
    af54c57 View commit details
    Browse the repository at this point in the history
  10. MockFileSystemImpl additions: watch support, and a 'when' function fo…

    …r hooking callbacks and change notifications.
    gruehle committed Oct 24, 2013
    Configuration menu
    Copy the full SHA
    94a9cb8 View commit details
    Browse the repository at this point in the history
  11. Merge branch 'glenn/file-system' of https://github.com/adobe/brackets

    …into glenn/file-system
    gruehle committed Oct 24, 2013
    Configuration menu
    Copy the full SHA
    e0ebe14 View commit details
    Browse the repository at this point in the history
  12. move FileSystemEntry.isFile() and isDirectory() to FileSystemEntry.is…

    …File and isDirectory; create new FileSystemStats class and update FileSystemEntry.stat to callback with a FileSystemStats object
    Ian Wehrman committed Oct 24, 2013
    Configuration menu
    Copy the full SHA
    f8c86db View commit details
    Browse the repository at this point in the history
  13. Merge branch 'glenn/file-system' of https://github.com/adobe/brackets

    …into glenn/file-system
    
    Conflicts:
    	src/project/ProjectManager.js
    Ian Wehrman committed Oct 24, 2013
    Configuration menu
    Copy the full SHA
    d6e2486 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2013

  1. Fix regression in RecentProjects: current project was getting listed at

    top of menu instead of being excluded.
    peterflynn committed Oct 25, 2013
    Configuration menu
    Copy the full SHA
    858e452 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'brackets' into glenn/file-system

    Conflicts:
    	src/LiveDevelopment/LiveDevelopment.js
    Ian Wehrman committed Oct 25, 2013
    Configuration menu
    Copy the full SHA
    ea9196d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8066e30 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    eb49314 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ab3cb48 View commit details
    Browse the repository at this point in the history
  6. Merge branch 'glenn/file-system' of https://github.com/adobe/brackets

    …into glenn/file-system
    gruehle committed Oct 25, 2013
    Configuration menu
    Copy the full SHA
    b21ae30 View commit details
    Browse the repository at this point in the history
  7. Compatibility shims for frequently-used FileIndexManager & NativeFile…

    …System
    
    APIs, to give (some) extensions a little more time to complete the
    migration.
    peterflynn committed Oct 25, 2013
    Configuration menu
    Copy the full SHA
    354a838 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    54527b6 View commit details
    Browse the repository at this point in the history
  9. Merge branch 'glenn/file-system' of https://github.com/adobe/brackets

    …into glenn/file-system
    gruehle committed Oct 25, 2013
    Configuration menu
    Copy the full SHA
    2ecc22f View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    173442c View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2013

  1. Merge branch 'brackets' into glenn/file-system

    Conflicts:
    	src/document/DocumentCommandHandlers.js
    	src/document/DocumentManager.js
    	src/editor/ImageViewer.js
    	src/utils/DragAndDrop.js
    Ian Wehrman committed Oct 26, 2013
    Configuration menu
    Copy the full SHA
    67c19d0 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'glenn/file-system' of https://github.com/adobe/brackets

    …into glenn/file-system
    Ian Wehrman committed Oct 26, 2013
    Configuration menu
    Copy the full SHA
    400ed27 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'brackets' into glenn/file-system

    Conflicts:
    	src/project/ProjectManager.js
    Ian Wehrman committed Oct 26, 2013
    Configuration menu
    Copy the full SHA
    e9a5a6b View commit details
    Browse the repository at this point in the history
  4. Precompute FileSystemEntry.name and only update it when FileSystemEnt…

    …ry._path is updated
    Ian Wehrman committed Oct 26, 2013
    Configuration menu
    Copy the full SHA
    c5279bc View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2013

  1. Configuration menu
    Copy the full SHA
    dd69c94 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'brackets' into glenn/file-system

    Conflicts:
    	src/search/FindInFiles.js
    Ian Wehrman committed Oct 28, 2013
    Configuration menu
    Copy the full SHA
    980acaf View commit details
    Browse the repository at this point in the history
  3. Unit tests for various file system race conditions, ensuring that cal…

    …lbacks
    
    always run before watcher results for the same operation. (Essentially
    testing the FileSystem._watchResults queue functionality).
    peterflynn committed Oct 28, 2013
    Configuration menu
    Copy the full SHA
    992bdaa View commit details
    Browse the repository at this point in the history
  4. Add more FileSystem tests.

    gruehle committed Oct 28, 2013
    Configuration menu
    Copy the full SHA
    3e67b04 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4a0929e View commit details
    Browse the repository at this point in the history
  6. Remove NativeFileSystem tests

    gruehle committed Oct 28, 2013
    Configuration menu
    Copy the full SHA
    04e4c6c View commit details
    Browse the repository at this point in the history
  7. Merge with origin/master

    gruehle committed Oct 28, 2013
    Configuration menu
    Copy the full SHA
    70c9453 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2013

  1. 2 Configuration menu
    Copy the full SHA
    ddb3500 View commit details
    Browse the repository at this point in the history
  2. - Change ScopeManager to use getDocumentText() for efficiency

    - Add FileSystem.isAbsolutePath() utility function
    - Update FileSystem docs to reflect latest at
    https://github.com/adobe/brackets/wiki/File-System
    peterflynn committed Oct 29, 2013
    Configuration menu
    Copy the full SHA
    84c0e1c View commit details
    Browse the repository at this point in the history
  3. Call back with an empty array of entries and stats (instead of undefi…

    …ned arguments) if readdir returns without either error or entries; remove an unused variable.
    Ian Wehrman committed Oct 29, 2013
    Configuration menu
    Copy the full SHA
    d2723a4 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'glenn/file-system' of https://github.com/adobe/brackets

    …into glenn/file-system
    Ian Wehrman committed Oct 29, 2013
    Configuration menu
    Copy the full SHA
    b2bd648 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2013

  1. Just check the entry's name, not it's entire path, when testing for b…

    …inary files
    Ian Wehrman committed Oct 30, 2013
    Configuration menu
    Copy the full SHA
    2362dd8 View commit details
    Browse the repository at this point in the history
  2. Add a FindIn perf timer

    Ian Wehrman committed Oct 30, 2013
    Configuration menu
    Copy the full SHA
    b7a8372 View commit details
    Browse the repository at this point in the history
  3. Execute read and stat calls in parallel in AppshellFileSystem.readFil…

    …e, resulting in a ~4-5% (>100ms) speedup for Brackets-sized find-in-files queries
    Ian Wehrman committed Oct 30, 2013
    Configuration menu
    Copy the full SHA
    4cddefc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3eac55a View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2013

  1. Don't try to get a file for an empty path.

    Ian Wehrman committed Oct 31, 2013
    Configuration menu
    Copy the full SHA
    ac5adc5 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'brackets' into glenn/file-system

    Conflicts:
    	src/LiveDevelopment/LiveDevelopment.js
    	src/document/DocumentCommandHandlers.js
    	src/project/ProjectManager.js
    Ian Wehrman committed Oct 31, 2013
    Configuration menu
    Copy the full SHA
    0942969 View commit details
    Browse the repository at this point in the history
  3. Remove change/rename console.log statements

    Ian Wehrman committed Oct 31, 2013
    Configuration menu
    Copy the full SHA
    e33f78b View commit details
    Browse the repository at this point in the history
  4. Remove an unused instance of NativeFileSystem

    Ian Wehrman committed Oct 31, 2013
    Configuration menu
    Copy the full SHA
    507a5c0 View commit details
    Browse the repository at this point in the history
  5. Dial back the unindexed entry warning a bit.

    Ian Wehrman committed Oct 31, 2013
    Configuration menu
    Copy the full SHA
    0cb5182 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2013

  1. Fix two bugs in filesystem port of DocumentCommandHandlers:

    * 'Close Others' with one unsaved file did nothing (after choosing to
    save) -- this was a merge error in doSave().
    * 'Close Others' with multiple unsaved files doesn't close working set
    items that have never been opened yet (after choosing to save) -- appears
    to be a bug in the code we copied from PR #5497 (saveFileList() &
    _doCloseDocumentList() were not on the same page about the list of files
    meant that was returned from saveFileList()). Added a note in the PR.
    
    Also rename 'savedFiles' vars to avoid confusion over whether they include
    files that weren't dirty. And improve docs.
    peterflynn committed Nov 1, 2013
    Configuration menu
    Copy the full SHA
    fa8c824 View commit details
    Browse the repository at this point in the history
  2. Fix & re-enable inline editor unit test on file-system branch -- ensure

    test window is aware of newly added test file.
    Update SpecRunnerUtils.createTextFile() (only used here) to require a
    specific FileSystem argument to avoid this pitfall in the future.
    peterflynn committed Nov 1, 2013
    Configuration menu
    Copy the full SHA
    998f619 View commit details
    Browse the repository at this point in the history
  3. Respond to review comments.

    gruehle committed Nov 1, 2013
    2 Configuration menu
    Copy the full SHA
    bc831b9 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'glenn/file-system' of https://github.com/adobe/brackets

    …into glenn/file-system
    gruehle committed Nov 1, 2013
    Configuration menu
    Copy the full SHA
    f04b2d2 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2013

  1. Configuration menu
    Copy the full SHA
    c073637 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'brackets' into glenn/file-system

    Conflicts:
    	src/project/ProjectManager.js
    Ian Wehrman committed Nov 2, 2013
    Configuration menu
    Copy the full SHA
    004ff69 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'glenn/file-system' of https://github.com/adobe/brackets

    …into glenn/file-system
    Ian Wehrman committed Nov 2, 2013
    Configuration menu
    Copy the full SHA
    79335bd View commit details
    Browse the repository at this point in the history
  4. Double quotes

    gruehle committed Nov 2, 2013
    Configuration menu
    Copy the full SHA
    3dde788 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2013

  1. Implement the clarified spec of FileSystemImpl.readdir and Directory.…

    …getContents suggested by @gruehle
    Ian Wehrman committed Nov 4, 2013
    2 Configuration menu
    Copy the full SHA
    34085c5 View commit details
    Browse the repository at this point in the history
  2. Avoid duplicated implementations of filtering ProjectManager.getAllFi…

    …les()
    
    down to just CSS files - provide a new utility function to filter files
    based on Language id
    peterflynn committed Nov 4, 2013
    Configuration menu
    Copy the full SHA
    2184802 View commit details
    Browse the repository at this point in the history
  3. Adjust the implementation of Directory.getContents to also return an …

    …array of FileSystemStats objects for each of the returned directory contents.
    Ian Wehrman committed Nov 4, 2013
    Configuration menu
    Copy the full SHA
    779019d View commit details
    Browse the repository at this point in the history
  4. Merge branch 'glenn/file-system' of https://github.com/adobe/brackets

    …into glenn/file-system
    gruehle committed Nov 4, 2013
    Configuration menu
    Copy the full SHA
    13562ee View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2013

  1. Replace references to FileEntry and DirectoryEntry with references to…

    … File and Directory
    Ian Wehrman committed Nov 5, 2013
    Configuration menu
    Copy the full SHA
    5967e2f View commit details
    Browse the repository at this point in the history
  2. Respond to review comments.

    gruehle committed Nov 5, 2013
    Configuration menu
    Copy the full SHA
    7561f75 View commit details
    Browse the repository at this point in the history
  3. Fix merge conflict

    gruehle committed Nov 5, 2013
    Configuration menu
    Copy the full SHA
    7c1a450 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'brackets' into glenn/file-system

    Conflicts:
    	src/editor/ImageViewer.js
    Ian Wehrman committed Nov 5, 2013
    Configuration menu
    Copy the full SHA
    ce60edc View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2013

  1. Add FileSystemError.TOO_MANY_ENTRIES and a maxEntries option to FileS…

    …ystemEntry.visit with default 30,000
    Ian Wehrman committed Nov 6, 2013
    Configuration menu
    Copy the full SHA
    92ea58b View commit details
    Browse the repository at this point in the history
  2. Show what used to be the FileIndexManager too-many-files error dialog…

    … on project load if the filesystem watch fails with TOO_MANY_ENTRIES.
    Ian Wehrman committed Nov 6, 2013
    Configuration menu
    Copy the full SHA
    7bff28e View commit details
    Browse the repository at this point in the history
  3. Off-by-one error

    Ian Wehrman committed Nov 6, 2013
    Configuration menu
    Copy the full SHA
    cc52b50 View commit details
    Browse the repository at this point in the history
  4. If the file is created during by a write, send a change notification …

    …for the parent and not the new file.
    Ian Wehrman committed Nov 6, 2013
    Configuration menu
    Copy the full SHA
    af294e1 View commit details
    Browse the repository at this point in the history
  5. Add tests for FileSystemEntry.visit

    Ian Wehrman committed Nov 6, 2013
    Configuration menu
    Copy the full SHA
    d1b698c View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2013

  1. Only mark one category of LanguageManager tests as integration tests …

    …instead of the entire suite; remove some redundant cleanup
    Ian Wehrman committed Nov 7, 2013
    Configuration menu
    Copy the full SHA
    4d6c73d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0fd2e14 View commit details
    Browse the repository at this point in the history
  3. Merge

    gruehle committed Nov 7, 2013
    2 Configuration menu
    Copy the full SHA
    dffad5f View commit details
    Browse the repository at this point in the history
  4. Fix the failFast callback err logic in FSE.visit

    Ian Wehrman committed Nov 7, 2013
    Configuration menu
    Copy the full SHA
    629bc8f View commit details
    Browse the repository at this point in the history
  5. Do not watch filtered directories

    Ian Wehrman committed Nov 7, 2013
    Configuration menu
    Copy the full SHA
    4d83481 View commit details
    Browse the repository at this point in the history
  6. Directory.getContents has four parameters, the last of which is stats…

    …Errors
    Ian Wehrman committed Nov 7, 2013
    Configuration menu
    Copy the full SHA
    b34a1a3 View commit details
    Browse the repository at this point in the history
  7. Initialize _watchResults in the constructor

    Ian Wehrman committed Nov 7, 2013
    Configuration menu
    Copy the full SHA
    1b626bd View commit details
    Browse the repository at this point in the history
  8. Wrap sensitive callbacks in a try-catch block

    Ian Wehrman committed Nov 7, 2013
    Configuration menu
    Copy the full SHA
    453f472 View commit details
    Browse the repository at this point in the history
  9. Unbreak FileSystem.init

    Ian Wehrman committed Nov 7, 2013
    Configuration menu
    Copy the full SHA
    7b5042e View commit details
    Browse the repository at this point in the history
  10. More cleanup

    gruehle committed Nov 7, 2013
    Configuration menu
    Copy the full SHA
    d77cf16 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    7595fdc View commit details
    Browse the repository at this point in the history
  12. Merge branch 'glenn/file-system' of https://github.com/adobe/brackets

    …into glenn/file-system
    Ian Wehrman committed Nov 7, 2013
    Configuration menu
    Copy the full SHA
    3280c1d View commit details
    Browse the repository at this point in the history
  13. Use FileSystem change/rename events instead of the old ProjectManager…

    … projectFilesChanged event
    Ian Wehrman committed Nov 7, 2013
    Configuration menu
    Copy the full SHA
    6cbe02c View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    b5e5da5 View commit details
    Browse the repository at this point in the history
  15. Replace try-catch-finally callback blocks in the filesystem with try-…

    …finally blocks when possible.
    Ian Wehrman committed Nov 7, 2013
    Configuration menu
    Copy the full SHA
    609d873 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2013

  1. Reset default FSE.visit maxDepth to 100

    Ian Wehrman committed Nov 8, 2013
    Configuration menu
    Copy the full SHA
    60c8cd0 View commit details
    Browse the repository at this point in the history