Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label focus after selection #261

Closed
joe-replin opened this issue May 5, 2023 · 5 comments · Fixed by #266
Closed

Label focus after selection #261

joe-replin opened this issue May 5, 2023 · 5 comments · Fixed by #266
Assignees
@oliverfoster
Labels
accessibility bug released

Comments

@joe-replin
Copy link
Contributor

Subject of the issue/enhancement/features

When using JAWS or NVDA after activating the forward or back button in the narrative component, the slide is changed and focus can be visually seen landing on the heading of the new slide. However, the first piece of information announced after activation is the label of the forward button instead of the new slide heading.

For example, if I am viewing narrative item 1 and move forward to narrative item 2, NVDA announces, "Forward to narrative item 3 (item 3 of 3), Narrative item 2". This is before if eventually announced the item heading.

If I am viewing narrative item 2 and move forward to narrative item 3, JAWS announces the trickle aria-label.

For example, if I am viewing narrative item 2 and move back to narrative item 1, JAWS announces, "Forward to narrative item 3 (item 3 of 3), Narrative item 2". This is before if eventually announced the item heading.

Your environment

  • FW v 5.30.3
  • Narrative v7.4.5
  • Firefox
  • Jaws 2023 & NVDA
  • Windows

Expected behaviour

Ensure that when users move between slides of the narrative component, that navigation buttons are not being announced unless they receive focus.

Actual behaviour

The headings are being focused but the navigation buttons are being read aloud.
@joe-replin joe-replin assigned joe-replin and unassigned joe-replin May 5, 2023
@oliverfoster
Copy link
Member

That sounds exactly like the behaviour of narrative before this pr https://github.com/adaptlearning/adapt-contrib-narrative/pull/259/files

@joe-replin
Copy link
Contributor Author

This is happening after that PR as I am using Narrative v7.4.5.
In Chrome & JAWS, this is working as intended. The issues are present when using a combination of Firefox & JAWS.

@joe-replin
Copy link
Contributor Author

joe-replin commented May 15, 2023 •
edited
Loading

Upon further investigation, even though this is scripted to wait to move the element focus until after the animation has reached its conclusion, focus is being given to the correct element in the focus order, but the element being read aloud is the one after the focused element in the list, which in some cases screen readers will read the trickle button aloud.

Setting up a break point at the point of focus change, however, allows the correct element to be read aloud after the focus change.

@oliverfoster
Copy link
Member

oliverfoster commented May 15, 2023 •
edited
Loading

It'll be because the element isn't "readable" at the point of focusing, which is what "waiting for animation to finish" is about.
https://github.com/adaptlearning/adapt-contrib-core/blob/c54cffec551a2311ab22c60b87a0a80274bf6aaa/js/a11y.js#L709

oliverfoster added a commit that referenced this issue May 15, 2023
@oliverfoster
Fix: Delay button update until after focus (fixes #261)
a22aaa8
@oliverfoster oliverfoster mentioned this issue May 15, 2023
Merged
@oliverfoster oliverfoster self-assigned this May 15, 2023
joe-allen-89 pushed a commit that referenced this issue May 26, 2023
@oliverfoster
Fix: Delay button update until after focus (fixes #261) (#266)
949ee68
github-actions bot pushed a commit that referenced this issue May 26, 2023
@semantic-release-bot
Chore(release): 7.4.8 [skip ci]
9dca259 
## [7.4.8](v7.4.7...v7.4.8) (2023-05-26)

### Fix

* Delay button update until after focus (fixes #261) (#266) ([949ee68](949ee68)), closes [#261](#261) [#266](#266)
@github-actions
Copy link

🎉 This issue has been resolved in version 7.4.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to robertmausser/adapt-contrib-narrative that referenced this issue Jul 10, 2023
@semantic-release-bot
Chore(release): 5.1.0 [skip ci]
a5579b7 
# [5.1.0](v5.0.2...v5.1.0) (2023-07-10)

### chore

* added package.json ([c80dc92](c80dc92))
* added package.json ([eef9b5d](eef9b5d)), closes [#3072](https://github.com/robertmausser/adapt-contrib-narrative/issues/3072)

### Fix

* _globals schema nesting (adaptlearning#253) ([2cdb7ae](2cdb7ae)), closes [adaptlearning#253](https://github.com/robertmausser/adapt-contrib-narrative/issues/253)
* Added gitignore for release automation (adaptlearning#237) ([bacab53](bacab53)), closes [adaptlearning#237](https://github.com/robertmausser/adapt-contrib-narrative/issues/237)
* Added release automation (adaptlearning#234) ([dd45d5a](dd45d5a)), closes [adaptlearning#234](https://github.com/robertmausser/adapt-contrib-narrative/issues/234)
* Bump http-cache-semantics from 4.1.0 to 4.1.1 (adaptlearning#246) ([b613166](b613166)), closes [adaptlearning#246](https://github.com/robertmausser/adapt-contrib-narrative/issues/246)
* Convert to JSX, make progress indicators non-interactive (fixes adaptlearning#238 adaptlearning#244) ([7f7977a](7f7977a)), closes [adaptlearning#238](https://github.com/robertmausser/adapt-contrib-narrative/issues/238) [adaptlearning#244](https://github.com/robertmausser/adapt-contrib-narrative/issues/244)
* Delay button update until after focus (fixes adaptlearning#261) (adaptlearning#266) ([949ee68](949ee68)), closes [adaptlearning#261](https://github.com/robertmausser/adapt-contrib-narrative/issues/261) [adaptlearning#266](https://github.com/robertmausser/adapt-contrib-narrative/issues/266)
* Move breakpoint to medium from large (adaptlearning#264) ([65b1517](65b1517)), closes [adaptlearning#264](https://github.com/robertmausser/adapt-contrib-narrative/issues/264)
* Move button labels to span tags (fixes adaptlearning#268) ([433b7f9](433b7f9)), closes [adaptlearning#268](https://github.com/robertmausser/adapt-contrib-narrative/issues/268)
* Narrative focus being pulled on mobile fix (fixes adaptlearning#258) ([b60f8dc](b60f8dc)), closes [adaptlearning#258](https://github.com/robertmausser/adapt-contrib-narrative/issues/258)
* Narrative item header level calculation (adaptlearning#257) ([c5abd1b](c5abd1b)), closes [adaptlearning#257](https://github.com/robertmausser/adapt-contrib-narrative/issues/257)
* Prevent scrolling of container (fixes adaptlearning#254) (adaptlearning#255) ([cb6a6e9](cb6a6e9)), closes [adaptlearning#254](https://github.com/robertmausser/adapt-contrib-narrative/issues/254) [adaptlearning#255](https://github.com/robertmausser/adapt-contrib-narrative/issues/255)
* Removed focus-rect (fixes adaptlearning#242) ([c3692de](c3692de)), closes [adaptlearning#242](https://github.com/robertmausser/adapt-contrib-narrative/issues/242)
* Replace narrative view with hotgraphic view on parent (adaptlearning#265) ([8db789a](8db789a)), closes [adaptlearning#265](https://github.com/robertmausser/adapt-contrib-narrative/issues/265)
* Resolve page scroll when user selects last item (adaptlearning#232) ([f4cf921](f4cf921)), closes [adaptlearning#232](https://github.com/robertmausser/adapt-contrib-narrative/issues/232)
* Strapline overflow fix (adaptlearning#247) ([b011f23](b011f23)), closes [adaptlearning#247](https://github.com/robertmausser/adapt-contrib-narrative/issues/247)
* Version numbers removed from Readme files ([47c8a59](47c8a59))

### New

* Issue and pr project addition automation (refs adaptlearning/adapt_framework#3315) (adaptlearning#233) ([b6836d6](b6836d6)), closes [adaptlearning#233](https://github.com/robertmausser/adapt-contrib-narrative/issues/233)
* Normalize icons globally ([6c75165](6c75165))
* Provide default instruction text (fixes adaptlearning#240) (adaptlearning#241) ([7d3e560](7d3e560)), closes [adaptlearning#240](https://github.com/robertmausser/adapt-contrib-narrative/issues/240) [adaptlearning#241](https://github.com/robertmausser/adapt-contrib-narrative/issues/241)

### onItemsActiveChange

* remove underscore from parameter and return early ([2eab40b](2eab40b))
@swashbuck swashbuck mentioned this issue Aug 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverfoster oliverfoster

Labels
accessibility bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Delay button update until after focus (fixes #261) adaptlearning/adapt-contrib-narrative
2 participants
@joe-replin @oliverfoster