Skip to content

Commit

Permalink
onItemsActiveChange: remove underscore from parameter and return early
Browse files Browse the repository at this point in the history
(makes it consistent with onItemsVisitedChange)
  • Loading branch information
moloko committed Jun 17, 2020
1 parent d483532 commit 2eab40b
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions js/narrativeView.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,9 @@ define([
this.calculateWidths();
}

onItemsActiveChange(item, _isActive) {
if (_isActive === true) {
this.setStage(item);
}
onItemsActiveChange(item, isActive) {
if (!isActive) return;
this.setStage(item);
}

onItemsVisitedChange(item, isVisited) {
Expand Down

0 comments on commit 2eab40b

Please sign in to comment.