Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Add support for tooltip API (#88) #89

Merged
merged 5 commits into from
Oct 17, 2023
Merged

New: Add support for tooltip API (#88) #89

merged 5 commits into from
Oct 17, 2023

Conversation

joe-allen-89
Copy link
Contributor

#88

New

@joe-allen-89 joe-allen-89 self-assigned this Sep 8, 2023
@joe-allen-89 joe-allen-89 linked an issue Sep 8, 2023 that may be closed by this pull request
Tooltip label missing #88
Closed
oliverfoster
oliverfoster reviewed Sep 11, 2023
View reviewed changes
example.json Outdated Show resolved Hide resolved
@danielghost
Copy link
Contributor

danielghost commented Sep 15, 2023 •
edited
Loading

This was already included in 38b4d32 as part of #83.

@oliverfoster
Copy link
Member

oliverfoster commented Sep 15, 2023 •
edited
Loading

It was in the wrong column, not ready for review, had no associated pull request and no issue explaining that it was an implementation of the nav button api, Kirsty's issue is about the data-order attribute only. It was a branch of work no-one knew existed @danielghost

@danielghost
Copy link
Contributor

It was in the wrong column, not ready for review @danielghost

The readme hadn't yet been updated to reflect the attribute changes.

@oliverfoster
Copy link
Member

oliverfoster commented Sep 15, 2023 •
edited
Loading

Dan's branch has the navigation button api, Joe's has the readme updates, both have the tooltip api. Can I suggest a merger?

Joe if you revert your property name change to drawerLabel it should be simple enough to directly merge them.

issue/83...issue/88

@oliverfoster
Copy link
Member

oliverfoster commented Sep 19, 2023 •
edited
Loading

Pr for the merger. #90

I think we just need to revert navBarLabel to navigationBarLabel, to save unnecessarily changing the schema in a breaking way.

joe-allen-89 and others added 2 commits September 19, 2023 09:57
@joe-allen-89
schema defaults amended.
83843ab
@oliverfoster @danielghost
Fix: Utilise Navigation and Tooltip APIs (fixes #83)
0f25955 
* Fix: Utilise Navigation and Tooltip APIs (fixes #83).

* Small refactor and removal of hardcoded `_id` references.

---------

Co-authored-by: danielghost <daniel.ghost@kineo.com>
kirsty-hames
kirsty-hames approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected thanks. Testing on Mac Safari, Chrome and FF.

@oliverfoster oliverfoster merged commit 9a2ab1c into master Oct 17, 2023
@oliverfoster oliverfoster mentioned this pull request Oct 17, 2023
Closed
github-actions bot pushed a commit that referenced this pull request Oct 17, 2023
@semantic-release-bot
Chore(release): 5.4.0 [skip ci]
be74bb8 
# [5.4.0](v5.3.0...v5.4.0) (2023-10-17)

### New

* Add support for tooltip API (#88) (#89) ([9a2ab1c](9a2ab1c)), closes [#88](#88) [#89](#89)
@github-actions
Copy link

🎉 This PR is included in version 5.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

This was referenced Mar 13, 2024
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@eleanor-heath eleanor-heath eleanor-heath approved these changes

Assignees

@joe-allen-89 joe-allen-89

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tooltip label missing
5 participants
@joe-allen-89 @danielghost @oliverfoster @kirsty-hames @eleanor-heath