Skip to content

Commit

Permalink
Fix: languageselector updated to drawerLabel
Browse files Browse the repository at this point in the history
  • Loading branch information
joe-allen-89 committed Sep 13, 2023
1 parent 6b939c1 commit 95b754c
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,13 +101,13 @@ Label for the button that cancels the switch languages dialog.
Add to _course.json_ under _\_globals.\_extensions_.

### \_languagePicker (object):
The languagePicker object that contains values for `navigationBarLabel`, `languageSelector` and `_navTooltip` that contains `_isEnabled`, `text`.
The languagePicker object that contains values for `navigationBarLabel`, `drawerLabel` and `_navTooltip` that contains `_isEnabled`, `text`.

#### \navigationBarLabel (string):
Label shown next to the language picker button when navigation bar labels are enabled. Defaults to Language picker.

#### \languageSelector (string):
Aria label that appears at the top of the drawer displayed when language picker button is clicked. Defaults to Language selector.
#### \drawerLabel (string):
Aria label that appears at the top of the drawer displayed when language picker button is clicked. Defaults to language picker.

#### \_navTooltip (object):
The _navTooltip object that contains values for `_isEnabled` and `text`.
Expand Down
4 changes: 2 additions & 2 deletions properties.schema
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
"validators": [],
"translatable": true
},
"languageSelector": {
"drawerLabel": {
"type": "string",
"required": true,
"default": "Language selector",
"default": "Language Picker",
"inputType": "Text",
"validators": [],
"translatable": true
Expand Down
6 changes: 3 additions & 3 deletions schema/course.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@
"translatable": true
}
},
"languageSelector": {
"drawerLabel": {
"type": "string",
"title": "Language selector",
"default": "Language selector",
"title": "Drawer Label",
"default": "Language Picker",
"_adapt": {
"translatable": true
}
Expand Down
2 changes: 1 addition & 1 deletion templates/languagePickerDrawerView.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{{import_globals}}

<div class="languagepicker-drawer">
{{{a11y_aria_label _globals._extensions._languagePicker.languageSelector}}}
{{{a11y_aria_label _globals._extensions._languagePicker.drawerLabel}}}

<div class="languagepicker-drawer__inner" role="list">

Expand Down

0 comments on commit 95b754c

Please sign in to comment.