Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing data-order support for sorting navigation #83

Closed
kirsty-hames opened this issue Jun 16, 2023 · 1 comment
Closed

Missing data-order support for sorting navigation #83

kirsty-hames opened this issue Jun 16, 2023 · 1 comment
Assignees
@danielghost
Labels
bug released

Comments

@kirsty-hames
Copy link
Contributor

Subject of the issue

.nav__languagepicker-btn is missing the data-order attribute as per other navigation buttons in Adapt (see core PR for ref adaptlearning/adapt-contrib-core#61)

When changing languages via the language picker menu, navigation buttons switch places when the new language loads.

Your environment

  • v5.28.15 FW
  • v5.2.3 languagePicker
    I expect this will apply to both latest FW and languagePicker but I'll confirm.
@danielghost danielghost self-assigned this Jul 31, 2023
danielghost added a commit that referenced this issue Jul 31, 2023
@danielghost
Fix: Utilise Navigation and Tooltip APIs (fixes #83).
38b4d32
@danielghost danielghost mentioned this issue Sep 15, 2023
Merged
joe-allen-89 pushed a commit that referenced this issue Oct 17, 2023
@oliverfoster @danielghost
Fix: Utilise Navigation and Tooltip APIs (fixes #83)
0f25955 
* Fix: Utilise Navigation and Tooltip APIs (fixes #83).

* Small refactor and removal of hardcoded `_id` references.

---------

Co-authored-by: danielghost <daniel.ghost@kineo.com>
@oliverfoster
Copy link
Member

Fixed in #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielghost danielghost

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kirsty-hames @danielghost @oliverfoster