Fix: Add nav drawer icon override support (fixes #417) #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guywillis
requested review from
oliverfoster,
cahirodoherty-learningpool and
eleanor-heath
oliverfoster
reviewed
Feb 7, 2024
| @@ -20,8 +21,12 @@ | |||
| {{/each}} | |||
|
|
|||
| <button name="drawer" class="btn-icon nav__btn nav__drawer-btn js-nav-drawer-btn is-position-{{_config._drawer._position}}" data-event="toggleDrawer" aria-expanded="false" aria-label="{{_globals._accessibility._ariaLabels.navigationDrawer}}" data-order="{{_globals._extensions._drawer._navOrder}}" data-tooltip-id="drawer"> | |||
There was a problem hiding this comment.
Does this not become btn-text if there is no icon?
There was a problem hiding this comment.
Technically, it should yes. But I have taken the approach of leaving as is for the time being to reduce potential issues.
If we were to change the button class to btn-text in the navigation and have the theme set up to have a different font for buttons than body, then we could run into an issue whereby the fonts are different between buttons in the same space.
joe-allen-89
reviewed
Feb 9, 2024
lemmyadams
approved these changes
Feb 12, 2024
eleanor-heath
approved these changes
Feb 12, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
## [6.45.7](v6.45.6...v6.45.7) (2024-03-04) ### Chore * Delete .DS_Store (#503) ([f52c863](f52c863)), closes [#503](#503) ### Fix * Add nav drawer icon override support (fixes #417) (#498) ([d4a7715](d4a7715)), closes [#417](#417) [#498](#498) ### Upgrade * Bump ip from 1.1.8 to 1.1.9 (#501) ([6dad707](6dad707)), closes [#501](#501)
|
🎉 This PR is included in version 6.45.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #417
Fix
Preview of sidebar icons:
Dependency: adaptlearning/adapt_framework#3513