Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default values for Drawer button icon and position #534

Closed
swashbuck opened this issue May 8, 2024 · 0 comments · Fixed by #536
Closed

Add default values for Drawer button icon and position #534

swashbuck opened this issue May 8, 2024 · 0 comments · Fixed by #536
Assignees
@swashbuck
Labels
bug Something isn't working enhancement New feature or request

Comments

@swashbuck
Copy link
Contributor

Subject of the issue

In #498, the option to override the Drawer icon was introduced. For older courses upgrading to a newer version of adapt-contrib-core, the icon will be missing since there is no default value.

Unless there is a need to have the option of a nav button without an icon (e.g. when using nav text labels only), I think we should add a default value of icon-list with a position of auto.

Your environment

  • Core v6.46.7
  • FW v5.38.2

Screenshots

drawer-icon-missing
@swashbuck swashbuck added enhancement New feature or request bug Something isn't working labels May 8, 2024
@swashbuck swashbuck self-assigned this May 13, 2024
@swashbuck swashbuck mentioned this issue May 13, 2024
Merged
@swashbuck swashbuck changed the title Add default value for _drawer._iconClass Add default values for Drawer button icon and position May 13, 2024
oliverfoster pushed a commit that referenced this issue May 15, 2024
@swashbuck
Fix: Add default values for Drawer button icon and position (fixes #534…
58c84cb 
…) (#536)
github-actions bot pushed a commit that referenced this issue May 15, 2024
@semantic-release-bot
Chore(release): 6.46.9
6a0014b 
## [6.46.9](v6.46.8...v6.46.9) (2024-05-15)

### Fix

* Add default values for Drawer button icon and position (fixes #534) (#536) ([58c84cb](58c84cb)), closes [#534](#534) [#536](#536)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swashbuck swashbuck

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@swashbuck