Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SQLite state #1676

Merged
merged 38 commits into from
Feb 20, 2023
Merged

Add SQLite state #1676

merged 38 commits into from
Feb 20, 2023

Conversation

tanertopal
Copy link
Member

What does this implement/fix? Explain your changes.

Add new SQLite state.

danieljanes
danieljanes requested changes Feb 20, 2023
View reviewed changes
Copy link
Member

@danieljanes danieljanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I added a few suggestions and clarifying questions. Can we also mention this in the change log?

src/py/flwr/server/state/sqlite_state_test.py Outdated Show resolved Hide resolved
src/py/flwr/server/state/sqlite_state_test.py Outdated Show resolved Hide resolved
src/py/flwr/server/state/sqlite_state.py Outdated Show resolved Hide resolved
src/py/flwr/server/state/sqlite_state.py Outdated Show resolved Hide resolved
src/py/flwr/server/state/sqlite_state.py Outdated Show resolved Hide resolved
src/py/flwr/server/state/sqlite_state.py Outdated Show resolved Hide resolved
src/py/flwr/server/state/sqlite_state.py Outdated Show resolved Hide resolved
src/py/flwr/server/state/sqlite_state.py Outdated Show resolved Hide resolved
src/py/flwr/server/state/sqlite_state.py Outdated Show resolved Hide resolved
src/py/flwr/server/state/sqlite_state.py Outdated Show resolved Hide resolved
@danieljanes danieljanes mentioned this pull request Feb 20, 2023
Closed
tanertopal and others added 25 commits February 20, 2023 16:41
@tanertopal @danieljanes
Update src/py/flwr/server/state/in_memory_state.py
318f1bd 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@tanertopal @danieljanes
Update src/py/flwr/server/state/state_test.py
0fd9e3e 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@tanertopal @danieljanes
Update src/py/flwr/server/state/state_test.py
8ad6625 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@tanertopal @danieljanes
Update src/py/flwr/server/state/state_test.py
c47edbf 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@tanertopal @danieljanes
Update src/py/flwr/server/state/in_memory_state.py
2ccd417 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@tanertopal
Add review changes
15286a9
@tanertopal
Merge branch 'main' into improve_state
13e4b11
@tanertopal @danieljanes
Update src/py/flwr/server/state/state_test.py
762ed0d 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@tanertopal
Apply more review changes
a3f0206
@tanertopal
Merge branch 'improve_state' of github.com:adap/flower into improve_s…
ebd78a0 
…tate

* 'improve_state' of github.com:adap/flower:
  Update src/py/flwr/server/state/state_test.py
@tanertopal
Apply autoformat
37df132
@tanertopal
Merge branch 'improve_state' into add_sqlite_state
0071e35 
* improve_state:
  Apply autoformat
  Apply more review changes
  Update src/py/flwr/server/state/state_test.py
  Add review changes
  Fix quickstart Scikit Learn example (#1683)
  Fix PyTorch MNIST example doc (#1684)
  Update src/py/flwr/server/state/in_memory_state.py
  Update src/py/flwr/server/state/state_test.py
  Update src/py/flwr/server/state/state_test.py
  Update src/py/flwr/server/state/state_test.py
  Update src/py/flwr/server/state/in_memory_state.py
  Add baselines to good first contributions doc (#1679)
  Add FedProx to README (#1681)
  Add FedProx and FedAvg to baselines doc (#1680)
  Fix diagrams in docs (#1677)
  Correct testing loss in the quickstart_pytorch example (#1672)
  Improve testing in state
@tanertopal @danieljanes
Update src/py/flwr/server/state/sqlite_state.py
e4b6b3f 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@tanertopal @danieljanes
Update src/py/flwr/server/state/sqlite_state.py
7ed4ed4 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@tanertopal @danieljanes
Update src/py/flwr/server/state/sqlite_state.py
fd1bee0 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@tanertopal
Various fixes from code review
e950f71
@tanertopal
Merge branch 'main' into add_sqlite_state
708919c
@tanertopal
Fix SQL error
25eac16
@tanertopal
Merge branch 'main' into add_sqlite_state
61ca3bb 
* main:
  Improve testing in state (#1675)
@tanertopal @danieljanes
Update src/py/flwr/server/state/sqlite_state.py
96d6cfd 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@tanertopal
Merge branch 'main' into add_sqlite_state
5c974eb
@tanertopal @danieljanes
Update src/py/flwr/server/state/sqlite_state.py
464892b 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@tanertopal @danieljanes
Update src/py/flwr/server/state/sqlite_state.py
794acfa 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@tanertopal
Fix review requests
6ee5d9d
@tanertopal
Merge branch 'add_sqlite_state' of github.com:adap/flower into add_sq…
4c4565a 
…lite_state

* 'add_sqlite_state' of github.com:adap/flower:
  Update src/py/flwr/server/state/sqlite_state.py
  Update src/py/flwr/server/state/sqlite_state.py
tanertopal and others added 11 commits February 20, 2023 12:01
@tanertopal
Code review changes
1f5bc8f
@tanertopal @danieljanes
Update src/py/flwr/server/state/state_test.py
1403b67 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@tanertopal @danieljanes
Update src/py/flwr/server/state/sqlite_state.py
f9bbd7e 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@tanertopal
Code review changes
76fc6de
@tanertopal @danieljanes
Apply suggestions from code review
48ada79 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@tanertopal
Apply changes
9d449a1
@tanertopal
Improve handling for node_id=0
855c8e6
@tanertopal @danieljanes
Apply suggestions from code review
ab1d578 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@tanertopal @danieljanes
Apply suggestions from code review
8153706 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@tanertopal @danieljanes
Update src/py/flwr/common/__init__.py
2d12250 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@tanertopal @danieljanes
Update src/py/flwr/common/__init__.py
0285705 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@danieljanes danieljanes enabled auto-merge (squash) February 20, 2023 20:35
@danieljanes danieljanes merged commit 38c208b into main Feb 20, 2023
@danieljanes danieljanes deleted the add_sqlite_state branch February 20, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanertopal @danieljanes