Correct testing loss in the quickstart_pytorch example #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljanes
deleted the
1604-incorrect-calculation-of-running-loss-in-pytorch-example-code
branch
tanertopal
added a commit
that referenced
this pull request
Feb 20, 2023
* improve_state: Apply autoformat Apply more review changes Update src/py/flwr/server/state/state_test.py Add review changes Fix quickstart Scikit Learn example (#1683) Fix PyTorch MNIST example doc (#1684) Update src/py/flwr/server/state/in_memory_state.py Update src/py/flwr/server/state/state_test.py Update src/py/flwr/server/state/state_test.py Update src/py/flwr/server/state/state_test.py Update src/py/flwr/server/state/in_memory_state.py Add baselines to good first contributions doc (#1679) Add FedProx to README (#1681) Add FedProx and FedAvg to baselines doc (#1680) Fix diagrams in docs (#1677) Correct testing loss in the quickstart_pytorch example (#1672) Improve testing in state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#1604
What does this implement/fix? Explain your changes.
Makes the total testing loss in the
quickstart_pytorchexample more consistent by changing the reduction method of the criterion frommeantosum.