Issue #596: Add support for closing clips.

docs/getting_started/efficient_moviepy.rst

@@ -34,7 +34,7 @@ When to close() a clip
 
 When you create some types of clip instances - e.g. ``VideoFileClip`` or ``AudioFileClip`` - MoviePy creates a subprocess and locks the file. In order to release those resources when you are finished you should call the ``close()`` method.
 
-This is more important for more complex applications and it particularly important when running on Windows. While Python's garbage collector should eventually clean it the resources for you, clsing them makes them available earlier.
+This is more important for more complex applications and it particularly important when running on Windows. While Python's garbage collector should eventually clean it the resources for you, closing them makes them available earlier.
 
 However, if you close a clip too early, methods on the clip (and any clips derived from it) become unsafe.
 
@@ -134,4 +134,4 @@ For instance, when you are editing an animated GIF and want to check that it loo
 
     ipython_display(my_clip, autoplay=1, loop=1)
 
-Importantly, ``ipython_display`` actually embeds the clips physically in your notebook. The advantage is that you can move the notebook or put it online and the videos will work. The drawback is that the file size of the notebook can become very large. Depending on your browser, re-computing and displaying at video many times can take some place in the cache and the RAM (it will only be a problem for intensive uses). Restarting your browser solves the problem.
+Importantly, ``ipython_display`` actually embeds the clips physically in your notebook. The advantage is that you can move the notebook or put it online and the videos will work. The drawback is that the file size of the notebook can become very large. Depending on your browser, re-computing and displaying at video many times can take some place in the cache and the RAM (it will only be a problem for intensive uses). Restarting your browser solves the problem.

moviepy/Clip.py

@@ -39,7 +39,6 @@ class Clip:
        this case their duration will be ``None``.
 
      """
-
     # prefix for all temporary video and audio files.
     # You can overwrite it with 
     # >>> Clip._TEMP_FILES_PREFIX = "temp_"

moviepy/audio/io/ffmpeg_audiowriter.py

@@ -135,12 +135,32 @@ def __del__(self):
 
     # Support the Context Manager protocol, to ensure that resources are cleaned up.
 
+    def close(self):
+        if self.proc:
+            self.proc.stdin.close()
+            self.proc.stdin = None
+            if self.proc.stderr is not None:
+                self.proc.stderr.close()
+                self.proc.stdee = None
+            # If this causes deadlocks, consider terminating instead.
+            self.proc.wait()
+            self.proc = None
+
+    def __del__(self):
+        # If the garbage collector comes, make sure the subprocess is terminated.
+        self.close()
+
+    # Support the Context Manager protocol, to ensure that resources are cleaned up.
+
     def __enter__(self):
         return self
 
     def __exit__(self, exc_type, exc_value, traceback):
         self.close()
 
+    def __exit__(self, exc_type, exc_value, traceback):
+        self.close()
+
 
 @requires_duration
 def ffmpeg_audiowrite(clip, filename, fps, nbytes, buffersize,

moviepy/video/io/VideoFileClip.py

@@ -85,6 +85,7 @@ def __init__(self, filename, has_mask=False,
 
         # Make a reader
         pix_fmt = "rgba" if has_mask else "rgb24"
+
         self.reader = FFMPEG_VideoReader(filename, pix_fmt=pix_fmt,
                                          target_resolution=target_resolution,
                                          resize_algo=resize_algorithm,

tests/test_PR.py

@@ -116,7 +116,6 @@ def test_PR_529():
     with VideoFileClip("media/fire2.mp4") as video_clip:
         assert video_clip.rotation == 180
 
-
 def test_PR_610():
     """
     Test that the max fps of the video clips is used for the composite video clip

tests/test_resourcereleasedemo.py

@@ -71,5 +71,6 @@ def test_failure_to_release_file():
 
             remove(local_video_filename)
             print("You are not running Windows, because that worked.")
+
         except OSError:  # More specifically, PermissionError in Python 3.
             print("Yes, on Windows this fails.")

tests/test_tools.py

@@ -2,9 +2,9 @@
 """Tool tests meant to be run with pytest. Taken from PR #121 (grimley517)."""
 import sys
 import time
+import pytest
 
 import moviepy.tools as tools
-import pytest
 
 
 def test_ext():
@@ -70,4 +70,4 @@ def test_5():
     assert file == b""
 
 if __name__ == '__main__':
-   pytest.main()
+    pytest.main()