Issue #596: Add support for closing clips. #608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add key support for close()
* FFMPEG_VideoWriter and FFMPEG_AudioWriter: Support close() and context managers.
* Clip: support close() and context manager. Doesn't do anything itself. The work is done in the subclasses that need it.
* Clip subclasses: Overrride close.
* Move away from depending on clients calling__del__(). Deleting can be left to Garbage Collector.
* CompositeVideoClip: Note: Don't close anything that wasn't constructed here. The client needs to be able to control the component clips.
* AudioFileClip: Was concerned that lambda might include a reference to reader that wasn't cleaned up by close, so changed it over to an equivalent self.reader. Probably has no effect, but feels safer.
* Update tests to use close().
* Note: While many tests pass on Linux either way, a large proportion of the existing unit tests fail on Windows without these changes.
* Include changes to many doctest examples - Demonstrate good practice in the examples.
* Also, migrate tests to use TEMPDIR where they were not using it.
* test_duration(): also corrected a bug in the test (described in Zulko#598). This bug is also been addressed in Zulko#585, so a merge will be required.
* Add two new test files:
* test_resourcereleasedemo exercises the path where close is not called and demonstrates that there is a consistent problem on Windows. Even after this fix, it remains a problem that if you don't call close, moviepg will leak locked files and subprocesses. Because the problem remains until the process ends, this is included in a separate test file.]
* test_resourcerelease demonstrates that when close() is called, the problem goes away.
* Update documentation to include usage tips for close()
Not included:
* Example code has not been updated to use close().
Julian-O
changed the title
|
Thank you for adding this, the code looks good to me, but I'm not a contributor, so we will need a contributor to review as well. |
tburrows13
added
the
feature
mgaitan
reviewed
Apr 16, 2018
| def __enter__(self): | ||
| return self | ||
|
|
||
| def __exit__(self, exc_type, exc_value, traceback): | ||
| self.close() | ||
|
|
||
| def __exit__(self, exc_type, exc_value, traceback): |
There was a problem hiding this comment.
this is repeated, right?
There was a problem hiding this comment.
You are right. Well spotted. That is an error. (It is of no consequence, but one should be deleted.)
|
Hi, Why is this issue closed? Is it fixed somewhere else? EDIT: Oh, It looks like it was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add key support for close()
Update tests to use close().
Add two new test files:
Update documentation to include usage tips for close()
Not included: