Simpler custom configuration and better related docs #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tburrows13
added
the
feature
…793_custom_configs
|
I would like to receive some feedback on this, guys. And please feel free to reword or correct the prose, particularly in the docs. |
tburrows13
reviewed
Apr 5, 2020
Add changelog entry Fix some string formatting errors
tburrows13
reviewed
Apr 5, 2020
tburrows13
reviewed
Apr 5, 2020
|
I've gone through your changes and made some tweaks to the wording in a few places. You've made a great improvement, and I think that it will now be much easier for users (especially windows users) to start using MoviePy. Once you've had a look at my comments and we've sorted them, then I'm happy to merge. |
|
@tburrows13 I've tried to clarify the example for setting config via dotenv and added the please, check and merge. |
tburrows13
approved these changes
Apr 15, 2020
# Conflicts: # CHANGELOG.md # docs/install.rst # moviepy/config_defaults.py # moviepy/video/io/ffmpeg_tools.py
keikoro
added
breaking-change
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal fix for #793 (and probably #1107, #883 and more issues related to custom config). It seems windows users have a lot of troubles particularly with the setup of ImageMagick and the instructions in the
readmewere totally outdated and complicated (even with a duplicated paragraph).The point is that, currently, the way to setup a "custom" path to the external tools is through environment variables and not editing a python module as the README said.
In addition to update the doc (please, feel free to correct/improve it, english is not my best skill)
, I deleted the
config_default.pymodule because is fairly useless. Environment variables are now documented, including how to set them via python or, optionally, via a dotenv file.As the config is via envars, functions to read/change config variables has no sense and were also removed.