Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os.getenv('FFMPEG_BINARY') is looked up at two locations #888

Closed
yurivict opened this issue Dec 16, 2018 · 1 comment
Closed

os.getenv('FFMPEG_BINARY') is looked up at two locations #888

yurivict opened this issue Dec 16, 2018 · 1 comment
Labels
lib-misc Issues pertaining to misc. 3rd-party libraries.

Comments

@yurivict
Copy link

yurivict commented Dec 16, 2018 •
edited
Loading

Settings are driven by:
https://github.com/Zulko/moviepy/blob/master/moviepy/config_defaults.py#L53

But then there is another ad-hoc lookup here:
https://github.com/Zulko/moviepy/blob/master/moviepy/editor.py#L25

It seems that the second place should use get_setting("FFMPEG_BINARY") instead.
@keikoro keikoro added the lib-misc Issues pertaining to misc. 3rd-party libraries. label Dec 16, 2018
@tburrows13
Copy link
Collaborator

Obsolete by #1109.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lib-misc Issues pertaining to misc. 3rd-party libraries.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yurivict @keikoro @tburrows13