Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test possible audio input to write_videofile #1037

Closed

Conversation

thenewguy
Copy link

@thenewguy thenewguy commented Nov 17, 2019

Provides tests for #876 and #1032

Intends to supersede #919 and #968

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 64.69% when pulling 0d9fb0b on thenewguy:apply-audio-removal-to-ffmpeg-input into c962808 on Zulko:master.

@coveralls
Copy link

coveralls commented Nov 17, 2019

Coverage Status

Coverage remained the same at 64.842% when pulling 1bbcd89 on thenewguy:apply-audio-removal-to-ffmpeg-input into c962808 on Zulko:master.

@thenewguy
Copy link
Author

These tests are passing - perhaps those issues are really about manually adding audio with extra ffmpeg parameters? Or maybe it is something to do with ffmpeg versions.

Anyways, I could not find write_videofile() audio options included anywhere in the tests so these should be merged.

@thenewguy
Copy link
Author

Closing in favor of #1039

@thenewguy thenewguy closed this Nov 18, 2019
@tburrows13 tburrows13 added the tests Related to individual tests in the test suite or running the test suite. label Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Related to individual tests in the test suite or running the test suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants