Skip to content

Commit

Permalink
Rename Pipfile.lock to pipfile.lock
Browse files Browse the repository at this point in the history
  • Loading branch information
@tburrows13
tburrows13 committed Oct 2, 2019
1 parent 15ed51c commit c962808
Showing 1 changed file with 0 additions and 0 deletions.
0 Pipfile.lock → pipfile.lock
View file
File renamed without changes.

4 comments on commit c962808

@keikoro
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tburrows13 Was wondering why this file was renamed – I noticed while going through the files in the root dir (pattern matching this + Pipfile wouldn't be as easy as it would normally be).

@tburrows13
Copy link
Collaborator Author

@tburrows13 tburrows13 commented on c962808 Oct 11, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that I thought at the time that it was more standard to have all lowercase filenames. I have no objections to changing it back.
I don't know much about this topic, but are we even supposed to have a pipfile and a pipfile.lock in our repo? There's no moviepy process for keeping pipfile.lock up-to-date and pipfile doesn't look like it is doing much at all. At one point we were using pipenv for the windows-based testing, but I got rid of that a while ago. Perhaps these files were created for that and we don't need them anymore (#931)?

@keikoro
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tburrows13 I only skimmed the linked issue, but yeah, it looks to me like pipenv was meant as pip alternative for those who prefer that. So if we've not kept it updated that's not very helpful, obviously, but I wouldn't remove it just yet. I'll bookmark it as a thing to look into at a later point. Their purpose is to define the packages needed + to pin versions, in any case. I guess they were inspired by package.json and package-lock.json used by npm in JavaScript projects.

But yes, I'd rename the file back. I think I've only ever seen them written Pipfile and Pipfile.lock. Will make a PR, maybe combine it with some minor changes to setup.py I've made on my end. They kind of go together topic-wise, and then it's not just this one tiny change.

@keikoro
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I just realised the pipenv thing would make for an ideal "good first issue" for someone who uses pipenv more regularly, so will create one for that.

Please sign in to comment.