Merge: Infrastructure for standalone plugins #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in subdirectories.
Co-authored-by: Weston Ruter <westonruter@google.com>
This adds a new module that will automatically enhance the `sizes` attribute of lazy-loaded images to support the new `auto` syntax. See: whatwg/html#4654 Fixes: #791.
Implement new module to use Speculation Rules API for prerendering documents on hover
Update initial auto-sizes module
Specifically reference `sizes="auto"` in the description, rather than "auto sizes". Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Prepare the auto-sizes module as a standalone plugin
…dalone-plugin Move Speculation Rules to new location as purely a standalone plugin
Remove `TODO` from `deploy-standalone-plugins.yml`
felixarntz
added
[Type] Enhancement
34 tasks
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @jeremyroman. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
westonruter
approved these changes
Mar 1, 2024
thelovekesh
approved these changes
Mar 1, 2024
mukeshpanchal27
approved these changes
Mar 1, 2024
| else | ||
| echo "The ${{ inputs.slug }} module slug is missing in the file plugins.json." | ||
| exit 1 | ||
| fi | ||
| else | ||
| # Load the JSON file and parse from "{name: {slug, version}, ...}" to "include: [{ name, slug, version }, ...]" | ||
| # for use in the matrix. | ||
| # For plugins, the "version" parameter is not included here; it will dynamically get it in its own job. | ||
|
|
There was a problem hiding this comment.
Suggested change
Remove empty line. Not blockers we can it later.
joemcgill
approved these changes
Mar 1, 2024
swissspidy
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See #656
trunkafterwards, as they're destructive, whereas the current state of thefeature/modules-to-pluginsbranch could in theory even be used to publish additional 2.x releases.trunk-with-legacy-modulesfromtrunkbefore merging those two PRs - just in case we may need it later.Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.