-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade notice to inform users of major change prior to 3.0.0 update #1019
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Co-authored-by: Pascal Birchler <pascalb@google.com>
Please take a look at #656 (comment) where we can coordinate the next steps on how to proceed with this PR and #1011. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukeshpanchal27 Thanks, this looks good to me, pending @westonruter's suggestion.
I'm putting a "request changes" similar to #1011, just until we decide how to proceed with this. See my above comment.
Co-authored-by: Weston Ruter <westonruter@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukeshpanchal27 LGTM, though we should probably merge #1011 first.
Summary
Fixes #655
Checklist
[Focus]
orInfrastructure
label.[Type]
label.no milestone
label.