Adds support for matching blocks with diacritics using lodash.deburr

[dsawardekar]

Description

Fixes #6387.

This PR updates the Gutenberg Block Inserter Menu to allow searching for terms that contain diacritics.

How has this been tested?

• I added unit tests for the normalizeTerm function and run the test suite successfully.
• I created a new sample block called 'Example Média Block'. And was able to match on this block in the inserter after my change.

Types of changes

New feature

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.standards
• My code has proper inline documentation.

[dsawardekar]

/cc @adamsilverstein Would love to get your feedback on this.

[paulwilde]

Couldn't this just be simplified to return deburr( term ).toLowerCase().trim(); and still be as readable?

[dsawardekar]

Yup, it could be. I've left it separate to allow for additional normalizations. I suspect there will be a few more like #8466.

[aduth]

I'm personally fine with this. If we want to get fancy-functional, we could also use Lodash's _.flow to compose them:

export const normalizeTerm = flow( [
	deburr,
	lowerCase,
	trim,
] );

• https://lodash.com/docs/4.17.10#lowerCase
• https://lodash.com/docs/4.17.10#trim

[aduth]

To be clearer, is it only removing leading and trailing whitespace, or all whitespace?

[dsawardekar]

Thanks, @aduth I've updated the comment message to add clarity.

[dsawardekar]

Note: The test suite failure is failing on a strange e2e error. The tests work fine locally.

    - Snapshot
    + Received
      "<!-- wp:paragraph -->
    - <p><strong></strong></p>
    + <p></p>
      <!-- /wp:paragraph -->"
      147 | 		await clickBlockAppender();
      148 | 		await pressWithModifier( 'mod', 'b' );
    > 149 | 		expect( await getEditedPostContent() ).toMatchSnapshot();
          | 		                                       ^
      150 | 
      151 | 		// When returning to Visual mode, backspace in selected block should
      152 | 		// reset to an unmodified default block.

[aduth]

@dsawardekar Our end-to-end tests have been less-than-reliable as of late. I've restarted the build on Travis. See also #6956.

[aduth]

I'm personally fine with this. If we want to get fancy-functional, we could also use Lodash's _.flow to compose them:

export const normalizeTerm = flow( [
	deburr,
	lowerCase,
	trim,
] );

• https://lodash.com/docs/4.17.10#lowerCase
• https://lodash.com/docs/4.17.10#trim

[aduth]

Conventionally we're including a newline before the @return JSDoc tag, per documentation example at:

https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/#functions

[aduth]

Also periods after each sentence.

[aduth]

I've pushed af48c05 to your branch to resolve my latest feedback regarding documentation style.

[mtias]

Thanks for the improvement!