Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for blocks with accents #6387

Closed
maximebj opened this issue Apr 24, 2018 · 2 comments
Closed

Search for blocks with accents #6387

maximebj opened this issue Apr 24, 2018 · 2 comments
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Enhancement A suggestion for improvement.

Comments

@maximebj
Copy link
Contributor

When you search for a block called for example "média" by typing "media", there is no result.

This bug will appear when every country will translate Gutenberg. On some countries like France, user won't be able to easily find some blocks.

It can be fixed by adding some keywords. but it's not ideal.

The search should search every accentuated character by its standard equivalent :

é è ê ë should be searched as a simple "e" for example.

@karmatosed karmatosed added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Apr 24, 2018
@karmatosed
Copy link
Member

I can replicate this, thanks for catching and lets see about getting a fix for this.

@braders
Copy link

braders commented Apr 26, 2018

WordPress core has the helpful remove_accents( $string ) function. If this was ported to the front-end (maybe as a package in WordPress/packages), then all strings could be normalised (i.e. without accents) before search comparisons are run.

@danielbachhuber danielbachhuber added the [Type] Enhancement A suggestion for improvement. label May 1, 2018
@danielbachhuber danielbachhuber added this to the WordPress 5.0 milestone May 1, 2018
@mtias mtias added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants