Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] File Block center align behavior #8303

Merged
merged 2 commits into from
Aug 1, 2018
Merged

[Fix] File Block center align behavior #8303

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
096b977
Fix file block center align behavior
Jul 30, 2018
cf35059
Introduce new selector for content container and apply CSS to it instead
Jul 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core-blocks/file/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@
align-items: center;
margin-bottom: 0;

> div {
Copy link
Member

@jorgefilipecosta jorgefilipecosta Jul 31, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Maybe we can add a class to this div something like wp-block-file__content-wrapper so we can target it using the class name instead of "> div" which is more vulnerable to a regression in a future change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds much better. Addressed in this commit. Thank you ❤️

flex-grow: 1;
}

&.is-transient {
@include loading_fade;
}
Expand Down