[Fix] File Block center align behavior #8303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core-blocks/file/editor.scss
Outdated
| @@ -4,6 +4,10 @@ | |||
| align-items: center; | |||
| margin-bottom: 0; | |||
|
|
|||
| > div { | |||
There was a problem hiding this comment.
Minor: Maybe we can add a class to this div something like wp-block-file__content-wrapper so we can target it using the class name instead of "> div" which is more vulnerable to a regression in a future change.
There was a problem hiding this comment.
This sounds much better. Addressed in this commit. Thank you ❤️
|
Thank you so much for the review @jorgefilipecosta ❤️ |
|
Thank you so much @noisysocks ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #8296 which reports the un-responsive alignment behavior of the file block in the editor when it is set to center align.
How has this been tested?
This PR has been tested by going through the following steps:
This was tested in WP 4.9.7, Gutenberg 3.3.0, Apache server with PHP 7.2.0 and MySQL 5.6.34. According to initial tests, the code doesn’t seem to affect any other areas.
Screenshots
Types of changes
This PR just adds a bit CSS to the block flexbox element's file child
div, so that it grows up to the remaining space in the container.Checklist: